-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate types in tree #23313
Deprecate types in tree #23313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (5)
packages/framework/fluid-framework/src/index.ts:57
- [nitpick] The comment explaining the ESLint disable directive is quite long and could be split into multiple lines for better readability.
/* eslint-disable import/export -- The event APIs are known to conflict, and this is intended as the exports via `@fluidframework/core-interfaces` are preferred over the deprecated ones from `@fluidframework/tree`. */
packages/dds/tree/src/index.ts:21
- The type name 'Listeners' is too generic and can cause confusion. Consider renaming it to something more specific like 'EventListeners'.
Listeners,
packages/dds/tree/src/index.ts:25
- The type name 'IsListener' is ambiguous. Consider renaming it to something more descriptive like 'IsEventListener'.
IsListener,
packages/dds/tree/src/index.ts:29
- The type name 'Listenable' is too generic and can cause confusion. Consider renaming it to something more specific like 'EventListenable'.
Listenable,
packages/dds/tree/src/index.ts:33
- The type name 'Off' is too generic and can cause confusion. Consider renaming it to something more specific like 'EventOff'.
Off,
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
bc86952
to
c6455be
Compare
0594542
to
c6455be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be mostly ready with test relocated to examples/utils/import-testing
🔗 No broken links found! ✅ Your attention to detail is admirable. linkcheck output
|
Add a changeset to deprecate types from @fluidframework/tree. Modify fluid-framework to re-export the non-deprecated APIs from core-interfaces.
Added basic test cases which covers importing a type from the three packages: tree, core-interfaces, and fluid-framework. These tests are added under examples.
Prior PR: #23183
ADO#25440