Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement blob support for Drafts #3648

Closed
vladsud opened this issue Sep 16, 2020 · 3 comments
Closed

Implement blob support for Drafts #3648

vladsud opened this issue Sep 16, 2020 · 3 comments
Assignees
Labels
area: runtime Runtime related issues status: stale
Milestone

Comments

@vladsud
Copy link
Contributor

vladsud commented Sep 16, 2020

https://github.com/microsoft/FluidFramework/pull/3573/files implements blob support.
Initial implementation does not include implementation for the following:

  1. Creation of blobs in detached container.
  2. Code to correctly serialize & de-serialize Drafts (detached container)
  3. Code to include blobs (from Update non-issues GitHub urls #1) in initial snapshot used to create a file.

Other designs are possible (including storage providing "staging" area for blobs, where blobs are uploaded as part of # 3, but before actual file creation, and storage "moves" blobs into file in some fashion).
We might need to think about them, but for simplest workflows (relatively small payloads), it's much better to use existing infrastructure and not add new concepts.
This might require some changes in existing implementation.

Note that the bare minimum here is

  1. we consistently fail when uploadBlob fails in detached state. I.e. feature is not implemented, and it's obvious to developers that it's limited to detached case.
  2. Uploads during Attaching state of container are waiting for container attach event before call is made to driver. I.e. we have container identify before calls are made
@ghost ghost added the triage label Sep 16, 2020
@tylerbutler tylerbutler added this to the September 2020 milestone Sep 16, 2020
@ghost ghost removed the triage label Sep 16, 2020
@tylerbutler tylerbutler added the area: runtime Runtime related issues label Sep 16, 2020
@SamBroner
Copy link
Contributor

Note: This is not required any upcoming timeline, but it's a good to have for performance tracking. The expectation is that this will create a bunch of questions, rather than answer them.
@tylerbutler

@anthony-murphy
Copy link
Contributor

related to #6128

@ghost ghost added the status: stale label Nov 29, 2021
@ghost
Copy link

ghost commented Nov 29, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed Dec 7, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues status: stale
Projects
None yet
Development

No branches or pull requests

6 participants