Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract away ContainerRuntime and revisit IContainerRuntime #3677

Closed
vladsud opened this issue Sep 18, 2020 · 2 comments
Closed

Abstract away ContainerRuntime and revisit IContainerRuntime #3677

vladsud opened this issue Sep 18, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@vladsud
Copy link
Contributor

vladsud commented Sep 18, 2020

IContainerRuntime represents "container level" API to some layers in the system (like request handler).
There is a lot of functionality provided by this interface, yet usage is tiny and some things are not used.
One of the reasons for that - we expose ContainerRuntime - particular implementation of that inteface.
The ideal workflow is for ContainerRuntime.load() to

  1. return IContainerRuntime, not ContainerRuntime
  2. Abstract it away behind factory function, such that there is little knowledge of that implementation outside ContainerRuntime / DataStoreContext layers.

That will allow us to better understand all the functionality that needs to be on that interface (might need to add), as well as functionality that we can remove from it.

@vladsud vladsud added the bug Something isn't working label Sep 18, 2020
@vladsud vladsud added this to the October 2020 milestone Sep 18, 2020
@vladsud vladsud self-assigned this Sep 18, 2020
@ghost ghost added the triage label Sep 18, 2020
@vladsud vladsud modified the milestones: October 2020, Next Oct 1, 2020
@curtisman curtisman added api area: runtime Runtime related issues and removed bug Something isn't working labels Oct 2, 2020
@ghost ghost added the status: stale label Jun 8, 2021
@ghost
Copy link

ghost commented Jun 8, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost added the status: stale label Dec 5, 2021
@ghost
Copy link

ghost commented Dec 5, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed Dec 13, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants