Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataObject: Deprecate Container Services #3799

Closed
skylerjokiel opened this issue Oct 1, 2020 · 5 comments
Closed

DataObject: Deprecate Container Services #3799

skylerjokiel opened this issue Oct 1, 2020 · 5 comments
Assignees
Labels
api area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct refactor Code refactoring and cleanup status: stale
Milestone

Comments

@skylerjokiel
Copy link
Contributor

The ContainerServices code in Aqueduct that is no longer being consumed and has been replaced by the Providers pattern.

This code needs to be removed.

@skylerjokiel skylerjokiel added the area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct label Oct 1, 2020
@skylerjokiel skylerjokiel added this to the October 2020 milestone Oct 1, 2020
@skylerjokiel skylerjokiel self-assigned this Oct 1, 2020
@curtisman curtisman added the refactor Code refactoring and cleanup label Oct 1, 2020
@danielroney
Copy link
Contributor

Per discussion at October milestone planning, I'm moving un-projected issues out to Next. This should get picked up in a Refactor effort in the near future.

@danielroney danielroney modified the milestones: October 2020, Next Oct 2, 2020
@leeviana
Copy link
Contributor

leeviana commented Oct 7, 2020

Was about to create an issue to start this conversation, good timing. I believe the last time I talked with Vlad he told me that we can't switch over to the provider pattern just yet because the current pattern expects injections from the scope level only and there's more work required before we can migrate. Can we get clarity on this and the timeline here? :)

@skylerjokiel
Copy link
Contributor Author

@leeviana , Coming in later here but I don't fully get your question. Seems like Justin has taken point on starting the Providers integration. Is there something clearly blocking here?

@leeviana
Copy link
Contributor

leeviana commented Nov 11, 2020

I just talked with justin and noticed that the "scope" object dependency Vlad was talking about really is just for getting the dependency global but any level can register things. Based on the code I saw, I believe we're unblocked, hopeful for some good progress here soon! :D

@vladsud vladsud changed the title Deprecate Container Services DataObject: Deprecate Container Services May 27, 2021
@ghost ghost added the status: stale label Nov 24, 2021
@ghost
Copy link

ghost commented Nov 24, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed Dec 2, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct refactor Code refactoring and cleanup status: stale
Projects
None yet
Development

No branches or pull requests

4 participants