Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFluidConfiguration should be removed #3854

Closed
2 tasks done
vladsud opened this issue Oct 6, 2020 · 2 comments · Fixed by #8939
Closed
2 tasks done

IFluidConfiguration should be removed #3854

vladsud opened this issue Oct 6, 2020 · 2 comments · Fixed by #8939
Assignees
Labels
api area: runtime Runtime related issues good first issue Good for newcomers refactor Code refactoring and cleanup
Milestone

Comments

@vladsud
Copy link
Contributor

vladsud commented Oct 6, 2020

I'm removing canReconnect from it as not used - if needed, we rather need to expose DeltaManager.reconnectMode.
The only property left is scopes and it's exposed incorrectly - it's a snapshot of scopes at the time of loading container, which is undefined in 99% of the cases as we do not have connection.
Instead, scopes should be exposed from DeltaManager.

While on it, we keep exposing property by property from DeltaManager.connection?.details
I feel like better approach is to define an object per connection (all "fixed" properties that do not change through connection) and expose it, vs. property by property.

@vladsud vladsud added the bug Something isn't working label Oct 6, 2020
@ghost ghost added the triage label Oct 6, 2020
@tylerbutler tylerbutler added the api label Oct 8, 2020
@tylerbutler tylerbutler added this to the Next milestone Oct 8, 2020
@ghost ghost added triage and removed triage labels Oct 8, 2020
@tylerbutler tylerbutler removed the triage label Oct 8, 2020
@ghost ghost added the triage label Oct 8, 2020
@tylerbutler tylerbutler removed bug Something isn't working triage labels Oct 8, 2020
@curtisman curtisman added area: runtime Runtime related issues refactor Code refactoring and cleanup labels Oct 26, 2020
@ghost ghost added the status: stale label Jun 8, 2021
@ghost
Copy link

ghost commented Jun 8, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@vladsud vladsud added the good first issue Good for newcomers label Jun 8, 2021
@ghost ghost removed the status: stale label Jun 8, 2021
@vladsud
Copy link
Contributor Author

vladsud commented Jul 12, 2021

@ChumpChief, is this something that will be taken care of by your refactoring work?
Is there any pre-work we can fork for someone else to help with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: runtime Runtime related issues good first issue Good for newcomers refactor Code refactoring and cleanup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants