Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We have two implementations of GarbageCollector class for an in-memory cache #4500

Closed
Tracked by #7347
vladsud opened this issue Dec 1, 2020 · 6 comments · Fixed by #9415
Closed
Tracked by #7347

We have two implementations of GarbageCollector class for an in-memory cache #4500

vladsud opened this issue Dec 1, 2020 · 6 comments · Fixed by #9415
Assignees
@NicholasCouri
Labels
area: runtime Runtime related issues good first issue Good for newcomers refactor Code refactoring and cleanup
Milestone
March 2022

Comments

@vladsud
Copy link
Contributor

vladsud commented Dec 1, 2020

Can we rationalize this?
@vladsud vladsud added the bug Something isn't working label Dec 1, 2020
@vladsud vladsud added this to the January 2021 milestone Dec 1, 2020
@ghost ghost added the triage label Dec 1, 2020
@curtisman curtisman added area: runtime Runtime related issues and removed bug Something isn't working triage labels Dec 1, 2020
@ghost ghost added the triage label Dec 1, 2020
@curtisman curtisman added the refactor Code refactoring and cleanup label Dec 1, 2020
@curtisman curtisman modified the milestones: January 2021, December 2020 Dec 1, 2020
@ghost ghost added triage and removed triage labels Dec 1, 2020
@jatgarg
Copy link
Contributor

jatgarg commented Dec 2, 2020

@vladsud Sorry I don't know anything about this as I haven't worked on it.

@vladsud
Copy link
Contributor Author

vladsud commented Dec 2, 2020

https://github.com/microsoft/FluidFramework/blob/0076d7e0c23fffcf5f6df042a1f49a6838c1b111/common/lib/common-utils/src/promiseCache.ts
https://github.com/microsoft/FluidFramework/blob/ae0afbe51902a335b1a6115651e35c9d45bac4df/packages/drivers/odsp-driver/src/odspCache.ts

Related PRs:
#1770
#2240

@curtisman curtisman removed the triage label Dec 2, 2020
@ghost ghost added the triage label Dec 2, 2020
@curtisman curtisman removed the triage label Dec 3, 2020
@ghost ghost added the triage label Dec 3, 2020
@markfields
Copy link
Member

markfields commented Dec 3, 2020 •
edited
Loading

Oh yeah, thanks for opening, I should have opened an issue I guess and not just left a comment in the code :)

@tylerbutler tylerbutler removed the triage label Dec 3, 2020
@anthony-murphy anthony-murphy modified the milestones: December 2020, Next Jan 4, 2021
@markfields markfields changed the title We have two implementations of GarbageCollector We have two implementations of GarbageCollector class for an in-memory cache Jan 29, 2021
@ghost ghost added the status: stale label Jul 28, 2021
@ghost
Copy link

ghost commented Jul 28, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@jatgarg
Copy link
Contributor

jatgarg commented Jul 28, 2021

comment

@ghost ghost removed the status: stale label Jul 28, 2021
@ghost ghost added the status: stale label Jan 24, 2022
@ghost
Copy link

ghost commented Jan 24, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@markfields markfields added the good first issue Good for newcomers label Jan 26, 2022
@vladsud vladsud mentioned this issue Mar 1, 2022
Closed
11 tasks
@vladsud vladsud assigned NicholasCouri and unassigned markfields Mar 1, 2022
@vladsud vladsud modified the milestones: Next, March 2022 Mar 1, 2022
This was referenced Mar 4, 2022
Closed
Merged
@markfields markfields mentioned this issue Mar 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicholasCouri NicholasCouri

Labels
area: runtime Runtime related issues good first issue Good for newcomers refactor Code refactoring and cleanup
Projects
None yet
Milestone
March 2022
7 participants
@tylerbutler @anthony-murphy @curtisman @markfields @NicholasCouri @vladsud @jatgarg