Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When parsing handles during load, enable loading the Fluid object locally #4950

Closed
agarwal-navin opened this issue Jan 28, 2021 · 2 comments
Closed
Assignees
Labels
area: runtime Runtime related issues status: stale

Comments

@agarwal-navin
Copy link
Contributor

Today, when handles are parsed and the underlying Fluid object is loaded, it always goes via the root. The handle resolution logic should be smart enough to load the Fluid object locally without going to the root if possible.

This will enable scenarios such as when a DDS is being loaded but the parent data store has not been loaded. If we always go through the root, it will not be able to reach the data store since it hasn't been loaded yet.

@vladsud
Copy link
Contributor

vladsud commented Apr 5, 2021

@agarwal-navin, with the move toward reusable components (see #4265), there will be more and more cases where data stores will store their dependencies as handles without their own DDSs and will need them to correctly operate. This, couple with potential circular references between data stores will make it impossible for data store to operate on partial state.
As such, I think we should strive to give control to upper layers (like Aqueduct) when data store is fully loaded (up to current sequence number) and registered in system (currently - with container runtime).

I think something like last edited should have some unique treatment here, but not in the form of giving control to random data object before it can operate on any handle.

Let's clarify scenario and clearly articulate success creteria.

@ghost ghost added the status: stale label Oct 2, 2021
@ghost
Copy link

ghost commented Oct 2, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed Oct 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues status: stale
Projects
None yet
Development

No branches or pull requests

2 participants