Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader Event on new Container resolve/request #5114

Closed
anthony-murphy opened this issue Feb 10, 2021 · 4 comments
Closed

Loader Event on new Container resolve/request #5114

anthony-murphy opened this issue Feb 10, 2021 · 4 comments
Labels
api design-required This issue requires design thought status: stale
Milestone

Comments

@anthony-murphy
Copy link
Contributor

i've actually been thinking we probably want an event on the loader for everytime a container is created, as i see hosts wanting to hook up logging, error handling, etc on every contianer loaded through their container

Originally posted by @anthony-murphy in #5112 (comment)

@ghost ghost added the triage label Feb 10, 2021
@anthony-murphy anthony-murphy added this to the Next milestone Feb 10, 2021
@ghost ghost removed the triage label Feb 10, 2021
@ghost ghost added the triage label Feb 10, 2021
@curtisman curtisman added api design-required This issue requires design thought and removed triage labels Feb 11, 2021
@curtisman
Copy link
Member

I think the feature would be great to have. Need to consider the consequence of having this global information exposed to every one that has access to the loader. This should only be exposed to the creator/owner of the loader/host only, and probably need to have a way to restrict it when passing it around.

@anthony-murphy
Copy link
Contributor Author

anthony-murphy commented Feb 11, 2021

great point. i actually think we need to split the loader interface in two, one that get's passed down and only has resolve/request, and the other that has create, and such for the host

@vladsud
Copy link
Contributor

vladsud commented May 27, 2021

I'd suggest accepting a "policy" object at Loader creation that controls certain aspects of each container in the loader and has visibility to new containers being created. This would simplify logistics around caching, for example. Today, we expose certain capabilities (like Container.forceReadonly, or pausing ops loading on boot) that have global impact (i.e. impact cached version of container that next user would get). And reverse - nested containers are not visible to host, and thus they can't apply same policy they are applying to external container. I'd make all these APIs only visible to this policy object, such that it could uniformly apply these policies to all containers (if it wants to), and leave it up to it decisions around caching and cashability of containers (possibly).

@ghost
Copy link

ghost commented Nov 23, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed Dec 1, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api design-required This issue requires design thought status: stale
Projects
None yet
Development

No branches or pull requests

3 participants