Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fluid-fetch tool does not handle errors correctly #5284

Closed
Tracked by #7347
vladsud opened this issue Feb 26, 2021 · 2 comments
Closed
Tracked by #7347

Fluid-fetch tool does not handle errors correctly #5284

vladsud opened this issue Feb 26, 2021 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vladsud
Copy link
Contributor

vladsud commented Feb 26, 2021

It should retry on retriable errors. Can it use retriable storage adapter for all APIs?
Note that I believe we added "repeat to 3 times" when downloading ops, it likely have to stay there as is given that adapter only applies to storage requests.

Error calling getSnapshotTree bB5H9BAAHAAAA
ERROR: Error
at EpochTrackerWithRedemption.checkForEpochError (E:\FluidFramework\packages\drivers\odsp-driver\dist\epochTracker.js:180:19)
at EpochTrackerWithRedemption.fetchAndParseAsJSON (E:\FluidFramework\packages\drivers\odsp-driver\dist\epochTracker.js:86:24)
at processTicksAndRejections (internal/process/task_queues.js:93:5)
at async EpochTrackerWithRedemption.fetchAndParseAsJSON (E:\FluidFramework\packages\drivers\odsp-driver\dist\epochTracker.js:210:20)
at async Function.timedExecAsync (E:\FluidFramework\packages\utils\telemetry-utils\dist\logger.js:308:25)
at async E:\FluidFramework\packages\drivers\odsp-driver\dist\odspDocumentStorageManager.js:735:34
at async OdspDocumentStorageService.readTree (E:\FluidFramework\packages\drivers\odsp-driver\dist\odspDocumentStorageManager.js:732:20)
at async OdspDocumentStorageService.getSnapshotTree (E:\FluidFramework\packages\drivers\odsp-driver\dist\odspDocumentStorageManager.js:348:22)
at async reportErrors (E:\FluidFramework\packages\tools\fetch-tool\dist\fluidFetchSnapshot.js:194:16)
at async fetchBlobsFromVersion (E:\FluidFramework\packages\tools\fetch-tool\dist\fluidFetchSnapshot.js:186:18)
statusCode: 429
retryAfterSeconds: 1000
errorType: "throttlingError"
canRetry: true

@vladsud vladsud added the bug Something isn't working label Feb 26, 2021
@vladsud vladsud added this to the April 2021 milestone Feb 26, 2021
@ghost ghost added the triage label Feb 26, 2021
@curtisman curtisman removed the triage label Mar 1, 2021
@vladsud vladsud modified the milestones: April 2021, May 2021 Mar 13, 2021
@vladsud vladsud modified the milestones: May 2021, June 2021 Apr 22, 2021
@vladsud vladsud modified the milestones: June 2021, July 2021 May 21, 2021
@vladsud vladsud modified the milestones: July 2021, Next Jun 29, 2021
@ghost ghost added the status: stale label Dec 27, 2021
@ghost
Copy link

ghost commented Dec 27, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@jatgarg
Copy link
Contributor

jatgarg commented Dec 28, 2021

Just commenting to keep it open from bot.

@ghost ghost removed the status: stale label Dec 28, 2021
@jatgarg jatgarg closed this as completed May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants