Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IDisposable to IDocumentStorageService #5980

Closed
znewton opened this issue Apr 28, 2021 · 3 comments
Closed

Add IDisposable to IDocumentStorageService #5980

znewton opened this issue Apr 28, 2021 · 3 comments
Assignees
Labels
area: driver Driver related issues status: stale
Milestone

Comments

@znewton
Copy link
Contributor

znewton commented Apr 28, 2021

Work Item

Describe the outcome you expect

DeltaManager should be able to use any IDocumentStorageService as its top level storage service, but currently RetriableDocumentStorage is required to be the top level so that dispose can be called. We should make all doc storage services "disposable" to increase flexibility.

Approach

  1. Extend IDisposable from IDocumentStorageService
  2. Add dispose methods to all doc storage services (even if they don't do anything) and pass through dispose calls to all internal doc storage services

Additional context

Follow-up to #5974

@znewton znewton self-assigned this Apr 28, 2021
@ghost ghost added the triage label Apr 28, 2021
@curtisman curtisman added the area: driver Driver related issues label Apr 29, 2021
@tylerbutler tylerbutler added this to the Next milestone Apr 30, 2021
@ghost ghost removed the triage label Apr 30, 2021
@ghost ghost added the status: stale label Nov 3, 2021
@ghost
Copy link

ghost commented Nov 3, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@znewton
Copy link
Contributor Author

znewton commented Nov 8, 2021

#8083 started the work for this issue by making IDocumentStorageService optionally extend IDisposable.

Next step: extend IDisposable from DocumentStorageServices once the above change is released

@ghost ghost removed the status: stale label Nov 8, 2021
@ghost ghost added the status: stale label May 8, 2022
@ghost
Copy link

ghost commented May 8, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed May 16, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues status: stale
Projects
None yet
Development

No branches or pull requests

3 participants