Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use annotateError instead of relying on LoggingError.addTelemetryProperties directly #6748

Closed
markfields opened this issue Jul 15, 2021 · 2 comments · Fixed by #6721
Closed
Assignees
Milestone

Comments

@markfields
Copy link
Member

This is a more flexible approach that can handle any arbitrary input, and lets us stop relying on an implementation detail (does this object inherit from LoggingError?) to be able to annotate it with logging properties.

@markfields
Copy link
Member Author

Already done via #6721, just wanted an issue to articulate the work stream better.

@markfields
Copy link
Member Author

Note that after further discussion with Tony and Vlad, I mostly undid this as part of #6764. We are doubling-down on our errors supporting telemetry props natively, so annotateError is gone, and we call addTelemetryProperties directly again, either on a LoggingError or a IFluidErrorBase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant