-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update error classes to implement IFluidErrorBase #6754
Comments
This is a big chunk of #5426. Might be broken into a few PRs, might not all fit in July, but we'll at least get started. |
Closing this as a dupe of #5426 at this point. Going to split out a few specific cases to prioritize, and otherwise we'll just do this as need arises. Also, related to #6980 since we'll have to mention |
This is a useful and bite-sized piece of #5426 so reopening as such. Steps:
|
Follow-on to #6749. Any error we raise ourselves should be an
IFluidErroBase
. They already areError
and have anerrorType
(already true due toIErrorBase
andIDriverErrorBase
), so this just means addfluidErrorCode
.This will also involve updating call sites to ensure we pass a valid (static) string as error code, and pull any variable stuff into other properties.
The text was updated successfully, but these errors were encountered: