Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled exception when fetching snapshot times out #6996

Closed
Tracked by #6686
vladsud opened this issue Aug 4, 2021 · 3 comments
Closed
Tracked by #6686

Unhandled exception when fetching snapshot times out #6996

vladsud opened this issue Aug 4, 2021 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vladsud
Copy link
Contributor

vladsud commented Aug 4, 2021

We are hitting this unhandled exception when fetch times out.
Any chance one of you can help me trace where we are lacking putting catch(() => {})?
@chensixx, I think you fixed one such case, this happens on recent bits in ODSP stress tests.

UnhandledPromiseRejection

Error
at createOdspNetworkError (/app/packages/utils/odsp-doclib-utils/dist/odspErrorUtils.js:123:21)
at Object.throwOdspNetworkError (/app/packages/utils/odsp-doclib-utils/dist/odspErrorUtils.js:161:26)
at /app/packages/drivers/odsp-driver/dist/odspUtils.js:82:33
at processTicksAndRejections (internal/process/task_queues.js:95:5)
at async Object.fetchAndParseAsJSONHelper (/app/packages/drivers/odsp-driver/dist/odspUtils.js:119:62)
at async EpochTrackerWithRedemption.fetchAndParseAsJSON (/app/packages/drivers/odsp-driver/dist/epochTracker.js:109:30)
at async EpochTrackerWithRedemption.fetchAndParseAsJSON (/app/packages/drivers/odsp-driver/dist/epochTracker.js:268:20)
at async /app/packages/drivers/odsp-driver/dist/fetchSnapshot.js:141:30
at async Function.timedExecAsync (/app/packages/utils/telemetry-utils/dist/logger.js:302:25)
at async OdspDocumentStorageService.fetchSnapshotCore (/app/packages/drivers/odsp-driver/dist/odspDocumentStorageManager.js:419:34)

@anthony-murphy
Copy link
Contributor

@chensixx is this bug ready to close now that the above pr is in?

@chensixx
Copy link
Contributor

no, we did not find the exception, the unit test was to rule out some scenarios. Jatin said we should add telemetry when unhandled exceptions happen. I will follow up when he is back

@jatgarg jatgarg modified the milestones: August 2021, September 2021 Sep 1, 2021
@chensixx chensixx modified the milestones: September 2021, Next Sep 15, 2021
@anthony-murphy anthony-murphy modified the milestones: Next, October 2021 Oct 1, 2021
@chensixx chensixx modified the milestones: October 2021, November 2021 Oct 26, 2021
@chensixx
Copy link
Contributor

chensixx commented Nov 3, 2021

#7642 changed to awaiting both promises, and we do not see the error anymore in stress tests. Resolving now.

@chensixx chensixx closed this as completed Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants