You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As IRuntimeFactory.instantiateRuntime has an existing parameter which can be used to check for this state, the existing property on IContainerContext is redundant. This should be done after we're able to safely do a breaking change in IRuntimeFactory (@fluidframework/container-definitions) by making the existing parameter mandatory.
Until the back-compat changes go in, we could deprecate the property by asserting its use, to ensure there is no current client using it.
Acceptance criteria:
existing in IRuntimeFactory.instantiateRuntime is mandatory
existing property from IContainerContext/ContainerContext is removed
RuntimeFactoryHelper is simplified to not check context.existing
ContainerRuntime is simplified to not check context.existing
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!
See #3429
As
IRuntimeFactory.instantiateRuntime
has anexisting
parameter which can be used to check for this state, the existing property onIContainerContext
is redundant. This should be done after we're able to safely do a breaking change inIRuntimeFactory
(@fluidframework/container-definitions
) by making theexisting
parameter mandatory.Until the back-compat changes go in, we could deprecate the property by asserting its use, to ensure there is no current client using it.
Acceptance criteria:
existing
inIRuntimeFactory.instantiateRuntime
is mandatoryexisting
property fromIContainerContext/ContainerContext
is removedRuntimeFactoryHelper
is simplified to not checkcontext.existing
ContainerRuntime
is simplified to not checkcontext.existing
The text was updated successfully, but these errors were encountered: