Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy existing property from IContainerContext #7223

Closed
andre4i opened this issue Aug 23, 2021 · 1 comment
Closed

Remove legacy existing property from IContainerContext #7223

andre4i opened this issue Aug 23, 2021 · 1 comment
Assignees
Labels
area: runtime Runtime related issues refactor Code refactoring and cleanup status: stale

Comments

@andre4i
Copy link
Contributor

andre4i commented Aug 23, 2021

See #3429

As IRuntimeFactory.instantiateRuntime has an existing parameter which can be used to check for this state, the existing property on IContainerContext is redundant. This should be done after we're able to safely do a breaking change in IRuntimeFactory (@fluidframework/container-definitions) by making the existing parameter mandatory.

Until the back-compat changes go in, we could deprecate the property by asserting its use, to ensure there is no current client using it.

Acceptance criteria:

  • existing in IRuntimeFactory.instantiateRuntime is mandatory
  • existing property from IContainerContext/ContainerContext is removed
  • RuntimeFactoryHelper is simplified to not check context.existing
  • ContainerRuntime is simplified to not check context.existing
@ghost ghost added the triage label Aug 23, 2021
@andre4i andre4i self-assigned this Aug 23, 2021
@curtisman curtisman added refactor Code refactoring and cleanup area: runtime Runtime related issues and removed triage labels Aug 26, 2021
@ghost ghost added the status: stale label Apr 25, 2022
@ghost
Copy link

ghost commented Apr 25, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed May 3, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues refactor Code refactoring and cleanup status: stale
Projects
None yet
Development

No branches or pull requests

2 participants