Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PureDataObject should ideally not expose (even as protected) context #8167

Closed
Tracked by #6272
vladsud opened this issue Nov 7, 2021 · 1 comment
Closed
Tracked by #6272
Assignees
Labels
bug Something isn't working status: stale

Comments

@vladsud
Copy link
Contributor

vladsud commented Nov 7, 2021

IFluidDataStoreContext specifically is interface for internal communication between data store runtime and container runtime.
Ideally it should not be even exposed from IFluidDataStoreRuntime interface (to begin with).

The only thing that DataObject cares about is context.createProps (deprecated) and context.containerRuntime (ideally not exposed directly, but rather as a curated list of functionality that objects built on top of data store runtime have to have access).

export abstract class PureDataObject<O extends IFluidObject = object, S = undefined, E extends IEvent = IEvent>
    extends EventForwarder<E>
    implements IFluidLoadable, IFluidRouter, IProvideFluidHandle, IFluidObject {

     ...
    /**
     * This context is used to talk up to the ContainerRuntime
     */
    protected readonly context: IFluidDataStoreContext;
@vladsud vladsud added the bug Something isn't working label Nov 7, 2021
@vladsud vladsud self-assigned this Nov 7, 2021
@ghost ghost added the status: stale label May 7, 2022
@ghost
Copy link

ghost commented May 7, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed May 15, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: stale
Projects
None yet
Development

No branches or pull requests

1 participant