You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@scottn12 in FF repo we are simply removing containerPath altogether ? Replace containerPath with Loader.request() seems off, as (I thought) we are not replacing anything. Maybe some examples would be helpful to show how to use Loader.request() as a substitute.
@ssimic2, that is correct, in the FF repo we are simply removing this API. We initially titled this task Replace containerPath with Loader.request() since we knew any usage of containerPath must be replaced with Loader.request(), but it turned out that it is only really used in partner repos, not the FF repo itself. Since we have broken down this item into multiple phases, we could rename this item to a more general title, for example Remove containerPath from DriverPreCheckInfo
Update, I believe we have refactored our way out of the containerPath dependency using Loader.request() in our repo instead, so this can be safely removed :)
scottn12
changed the title
Replace containerPath with Loader.request() - need to make sure it works though
Remove deprecated containerPath from DriverPreCheckInfoJan 19, 2022
Description
Remove the
containerPath
property from theDriverPreCheckInfo
interface in the following file:common/lib/driver-definitions/src/urlResolver.ts
.To replace its functionality, use
Loader.request().url
.Context: #4169
Phases
containerPath
in partner repos and replace withLoader.request()
as necessary. #8508DriverPreCheckInfo
and remove the deprecatedDriverPreCheckInfo.containerPath
#8548The text was updated successfully, but these errors were encountered: