Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated containerPath from DriverPreCheckInfo #8274

Closed
2 tasks done
Tracked by #8005
sonalivdeshpande opened this issue Nov 16, 2021 · 3 comments
Closed
2 tasks done
Tracked by #8005

Remove deprecated containerPath from DriverPreCheckInfo #8274

sonalivdeshpande opened this issue Nov 16, 2021 · 3 comments
Assignees
Labels
api deprecation Changes to a deprecated API
Milestone

Comments

@sonalivdeshpande
Copy link
Contributor

sonalivdeshpande commented Nov 16, 2021

Description

Remove the containerPath property from the DriverPreCheckInfo interface in the following file: common/lib/driver-definitions/src/urlResolver.ts.

To replace its functionality, use Loader.request().url.

Context: #4169

Phases

@ssimic2
Copy link

ssimic2 commented Jan 4, 2022

@scottn12 in FF repo we are simply removing containerPath altogether ? Replace containerPath with Loader.request() seems off, as (I thought) we are not replacing anything. Maybe some examples would be helpful to show how to use Loader.request() as a substitute.

@scottn12
Copy link
Contributor

scottn12 commented Jan 4, 2022

@ssimic2, that is correct, in the FF repo we are simply removing this API. We initially titled this task Replace containerPath with Loader.request() since we knew any usage of containerPath must be replaced with Loader.request(), but it turned out that it is only really used in partner repos, not the FF repo itself. Since we have broken down this item into multiple phases, we could rename this item to a more general title, for example Remove containerPath from DriverPreCheckInfo

@heliocliu heliocliu modified the milestones: December 2021, January 2022 Jan 6, 2022
@leeviana
Copy link
Contributor

Update, I believe we have refactored our way out of the containerPath dependency using Loader.request() in our repo instead, so this can be safely removed :)

@scottn12 scottn12 changed the title Replace containerPath with Loader.request() - need to make sure it works though Remove deprecated containerPath from DriverPreCheckInfo Jan 19, 2022
@scottn12 scottn12 added the api deprecation Changes to a deprecated API label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api deprecation Changes to a deprecated API
Projects
None yet
Development

No branches or pull requests

6 participants