Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete path from remoteObjectHandle.ts #8290

Closed
Tracked by #8005
sonalivdeshpande opened this issue Nov 16, 2021 · 3 comments · Fixed by #8419
Closed
Tracked by #8005

Delete path from remoteObjectHandle.ts #8290

sonalivdeshpande opened this issue Nov 16, 2021 · 3 comments · Fixed by #8419
Assignees
@sonalivdeshpande
Milestone
November 2021

Comments

@sonalivdeshpande
Copy link
Contributor

sonalivdeshpande commented Nov 16, 2021 •
edited
Loading

Remove path() from RemoteObjectHandle since it returns the absolute path.

The files affected are:

  1. packages\runtime\runtime-utils\src\remoteObjectHandle.ts
@sonalivdeshpande sonalivdeshpande mentioned this issue Nov 16, 2021
Closed
37 tasks
@ghost ghost added the triage label Nov 16, 2021
@sonalivdeshpande sonalivdeshpande self-assigned this Nov 16, 2021
@danielroney danielroney added this to the November 2021 milestone Nov 17, 2021
@ghost ghost removed the triage label Nov 17, 2021
@agarwal-navin
Copy link
Contributor

Sounds reasonable. Can you validate that this is not used anywhere and if it is, update it.

@sonalivdeshpande
Copy link
Contributor Author

Sounds reasonable. Can you validate that this is not used anywhere and if it is, update it.

I have checked Bohemia's codebase and it seems they are not using path

@sonalivdeshpande sonalivdeshpande mentioned this issue Nov 24, 2021
Merged
@agarwal-navin
Copy link
Contributor

I am curious if there a reason or a use case that you are removing this for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonalivdeshpande sonalivdeshpande

Labels
None yet
Projects
None yet
Milestone
November 2021
Development

Successfully merging a pull request may close this issue.

Remove path() from RemoteFluidObjectHandle class sonalivdeshpande/FluidFramework
3 participants
@agarwal-navin @sonalivdeshpande @danielroney