Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"clear" events on directory & map have ISequencedDocumentMessage payload #8481

Closed
Tracked by #6272
vladsud opened this issue Dec 7, 2021 · 1 comment · Fixed by #8484
Closed
Tracked by #6272

"clear" events on directory & map have ISequencedDocumentMessage payload #8481

vladsud opened this issue Dec 7, 2021 · 1 comment · Fixed by #8484
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vladsud
Copy link
Contributor

vladsud commented Dec 7, 2021

I do not see a point of exposing protocol-level messages in DDS API.
This seems weird. Can we remove it?

export interface ISharedDirectoryEvents extends ISharedObjectEvents {
    (event: "valueChanged", listener: (
        changed: IDirectoryValueChanged,
        local: boolean,
        op: ISequencedDocumentMessage | null,
        target: IEventThisPlaceHolder,
    ) => void);
    (event: "clear", listener: (
        local: boolean,
        op: ISequencedDocumentMessage | null,
        target: IEventThisPlaceHolder,
    ) => void);
}

export interface ISharedMapEvents extends ISharedObjectEvents {
    (event: "valueChanged", listener: (
        changed: IValueChanged,
        local: boolean,
        op: ISequencedDocumentMessage | null,
        target: IEventThisPlaceHolder) => void);
    (event: "clear", listener: (
        local: boolean,
        op: ISequencedDocumentMessage | null,
        target: IEventThisPlaceHolder
    ) => void);
}
@vladsud vladsud added the bug Something isn't working label Dec 7, 2021
@ChumpChief
Copy link
Contributor

Sounds good to me, also the valueChanged events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants