Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure time outbound ops are sitting in queue due to active batch #8947

Closed
Tracked by #9613
vladsud opened this issue Jan 31, 2022 · 1 comment · Fixed by #9738
Closed
Tracked by #9613

Measure time outbound ops are sitting in queue due to active batch #8947

vladsud opened this issue Jan 31, 2022 · 1 comment · Fixed by #9738
Assignees
Labels
bug Something isn't working perf
Milestone

Comments

@vladsud
Copy link
Contributor

vladsud commented Jan 31, 2022

With move toward batching being by default at JS turn granularity, we will change how long it takes from the time someone make a local change (DDS) to side-effects (op) to be sent to socket. If application spends a lot of time doing very expensive operations in response to user actions, this time might be long, and it will impact end-to-end op latency metrics we track (see first item below).

Related issues:

Ideally, we track all these metrics on a single op, such that we can easily do math on these metrics.

@andre4i - FYI.

@vladsud vladsud added bug Something isn't working perf labels Jan 31, 2022
@vladsud vladsud added this to the February 2022 milestone Jan 31, 2022
@vladsud vladsud modified the milestones: February 2022, March 2022 Feb 8, 2022
@vladsud vladsud assigned NicholasCouri and unassigned jatgarg Mar 1, 2022
@vladsud vladsud modified the milestones: March 2022, April 2022 Mar 8, 2022
@vladsud
Copy link
Contributor Author

vladsud commented Mar 30, 2022

Please see the comment I've just added in #8912 re stages.
This bug tracks tracking time between stages 1-2.
Please note that if we fix above mentioned bug, we could calculate that time (from all other metrics).
But I'd record it explicitly, as it will help us see if data is consistent (and thus makes sense), or vice versa (i.e., it will be easier to see bugs if any)

@NicholasCouri NicholasCouri mentioned this issue Apr 4, 2022
@NicholasCouri NicholasCouri linked a pull request Apr 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working perf
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants