Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record source of pausing inbound queue. #8974

Closed
jatgarg opened this issue Feb 2, 2022 · 1 comment
Closed

Record source of pausing inbound queue. #8974

jatgarg opened this issue Feb 2, 2022 · 1 comment
Labels
bug Something isn't working triage

Comments

@jatgarg
Copy link
Contributor

jatgarg commented Feb 2, 2022

Please note that there are many players who can pause op processing:

  1. DeltaScheduler
  2. ScheduleManager
  3. Summarizer
  4. Container (code proposal)

Given that API is generic and is available to all layers, more users may show up later.

From @vladsud
Add a system to track who's pausing ops, and a way to expose first/last/maybe all actors who caused ops to sit paused

  • I'd suggest for pause() to take some token (string, better - assert tag, clearly representing call site) and return another token (coutner). And for resume() to require token returned from pause() to match them and keep tracking who keeps queue paused. That would give us full picture and enforcement that pause() & resume are properly paired (and if not - we always know the offender)
  • A simpler system might be for resume() to accept token (like assert tag) to clearly articulate who was the last one to resume op processing, and thus we can log it with duration. This is less powerful system, but much simpler to implement for this task.

Originally posted by @vladsud in #8912 (comment)

@ghost ghost added the triage label Feb 2, 2022
@jatgarg jatgarg added the bug Something isn't working label Feb 2, 2022
@jatgarg
Copy link
Contributor Author

jatgarg commented May 26, 2022

workitem=491

@jatgarg jatgarg closed this as completed May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage
Projects
None yet
Development

No branches or pull requests

1 participant