Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech Debt: Move from this.existing to VisibilityState #9646

Closed
tyler-cai-microsoft opened this issue Mar 28, 2022 · 1 comment
Closed

Tech Debt: Move from this.existing to VisibilityState #9646

tyler-cai-microsoft opened this issue Mar 28, 2022 · 1 comment
Labels
area: runtime Runtime related issues refactor Code refactoring and cleanup
Milestone
Future

Comments

@tyler-cai-microsoft
Copy link
Contributor

tyler-cai-microsoft commented Mar 28, 2022 •
edited
Loading

Remove the existing flag from the data store context layer and replace it with how #9548 implements VisibilityState.

The flag is in packages/runtime/container-runtime/src/dataStoreContext.ts

To pass in visibility state here, we need to teach visibility state to ContainerRuntime / DataStores. We can (and probably should) do that but I don't want to do it in this PR. The existing flag drives other things in layers below data store context as well so we cannot easily remove it.

Originally posted by @agarwal-navin in #9548 (comment)
@ghost ghost added the triage label Mar 28, 2022
@tyler-cai-microsoft tyler-cai-microsoft mentioned this issue Mar 28, 2022
Merged
@tyler-cai-microsoft tyler-cai-microsoft added this to the Future milestone Mar 28, 2022
@tyler-cai-microsoft tyler-cai-microsoft added the refactor Code refactoring and cleanup label Mar 28, 2022
@tyler-cai-microsoft tyler-cai-microsoft changed the title Move from this.existing to VisibilityState Tech Debt: Move from this.existing to VisibilityState Mar 28, 2022
@tyler-cai-microsoft tyler-cai-microsoft added area: runtime Runtime related issues and removed triage labels Mar 28, 2022
@tyler-cai-microsoft
Copy link
Contributor Author

@andre4i what is your opinion on this?

@agarwal-navin agarwal-navin mentioned this issue Apr 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: runtime Runtime related issues refactor Code refactoring and cleanup
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@tyler-cai-microsoft