Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] [tests] FutureWarning: load_boston will be removed in scikit-learn 1.2. #4910

Closed
TremaMiguel opened this issue Dec 25, 2021 · 6 comments

Comments

@TremaMiguel
Copy link
Contributor

Description

Scikit-learn load_boston function will be removed in future version.

FutureWarning: Function load_boston is deprecated; `load_boston` is deprecated in 1.0 and will be removed in 1.2.

python-package tests test_engine.py, test_plotting.py, and test_sklearn.py uses boston dataset. Some of this tests have already been changed in #4895

Solution

Tests should be changed to another available regression dataset like load_diabetes or use proposed synthetic regression dataset.

@TremaMiguel
Copy link
Contributor Author

I'm open to develop this once there is an agreement on which dataset to use.

@StrikerRUS
Copy link
Collaborator

@TremaMiguel Thanks a lot for bringing this to our attention! But we have already created an issue for this problem: #4793. Please let's continue discussion there.

@gargargargarden
Copy link

it's just a version issue ,just don't bother

@jameslamb
Copy link
Collaborator

just don't bother

To be clear, for anyone finding this from search...LightGBM absolutely needs to fix this issue and remove uses of load_boston(), so that it can be tested in environments with scikit-learn>=1.2.

@mahmuudtolba
Copy link

just use the one on kaggle https://www.kaggle.com/datasets/vikrishnan/boston-house-prices

@jameslamb
Copy link
Collaborator

just use the one on kaggle https://www.kaggle.com/datasets/vikrishnan/boston-house-prices

Since this is the second comment like this, I'm locking this thread. To be clear:

  • there are ethical problems with the boston housing dataset
  • LightGBM's tests no longer rely on the boston housing dataset, and that's not going to change

@microsoft microsoft locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants