Artifacts potentially packs build scripts in wrong folder

[chris-sekira]

The Artifacts project has props/targets that get packed into the buildCrossTargeting folder. According to the NuGet package folder layout documentation this should be the buildMultiTargeting instead.

Unless this some kind of a legacy workaround/disambiguation, the folder should probably be renamed.

If I'm wrong on this and there's documentation that you've found for using the buildCrossTargeting, I'd be very appreciated if you could attach a link so that I can bookmark it for myself and request it's addition to the linked documentation above.

[jeffkl]

NuGet renamed the folder and supports both at least for a while. We should rename it.

NuGet/Home#4098

[chris-sekira]

Ah, google failed me. If buildMultiTargeting is the new standard, I'll look into submitting a change.

The oldest supported framework used here is net46, which was released before the linked issue's decision to move to buildMultiTargeting. Any chance we'd need to support buildCrossTargeting for anyone using older clients?

[jeffkl]

I can't think of a reason to keep both folders since people using older clients can just use an older package. I think renaming the folder is the right solution. Please feel free to contribute the change, otherwise I can get to it next week.

[chris-sekira]

@jeffkl I'll make the change during lunch.