Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile Grid Object Collection needs some rework #6237

Closed
gilbdev opened this issue Oct 8, 2019 · 2 comments
Closed

Tile Grid Object Collection needs some rework #6237

gilbdev opened this issue Oct 8, 2019 · 2 comments
Assignees

Comments

@gilbdev
Copy link
Contributor

gilbdev commented Oct 8, 2019

Describe the bug

Today, i tried to use Tile Grid Object Collection ..

first of all : "Centered" option is bugged (missing parenthesis in the code arround Column - 1)
secondly : does not derive from BaseObjectCollection or GridObjectCollection
third (link to 2nd) : the position is updated constantly in the Update() function (performance issue)
fourth : typo in property LayoutDireciton

lastly, not sure what the difference is from Grid, and documentation is not very explicit (and misleading, as we can think it inherit from Grid) :

TileGridObjectCollection.cs provides some additional options to GridObjectCollection

Expected behavior

minimal : fix 1 and 4
optimized: inherit from Grid and document better to tell what are the differences
radical : remove TileObjectCollection

Your Setup (please complete the following information)

  • Unity Version [2018.4.9f1]
  • MRTK Version [2.1 stabilization]

Additional context

I can help and make a PR based on decision

@gilbdev gilbdev added the Bug label Oct 8, 2019
@julenka julenka self-assigned this Nov 1, 2019
@stale
Copy link

stale bot commented Apr 9, 2020

This issue has been marked as stale by an automated process because it has not had any recent activity. It will be automatically closed in 30 days if no further activity occurs. If this is still an issue please add a new comment with more recent details and repro steps.

@stale stale bot added the Stale label Apr 9, 2020
@julenka
Copy link
Contributor

julenka commented Apr 13, 2020

Fixed by #6550 and subsequent improvements to GridObjectCollection

@julenka julenka closed this as completed Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants