Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default for UseStringArrayForQueryOptionsSchema should be false #614

Open
baywet opened this issue Dec 10, 2024 · 0 comments
Open

The default for UseStringArrayForQueryOptionsSchema should be false #614

baywet opened this issue Dec 10, 2024 · 0 comments
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days type:bug A broken experience type:regression A bug from previous release

Comments

@baywet
Copy link
Member

baywet commented Dec 10, 2024

OpenAPI.NET.OData/src/Microsoft.OpenApi.OData.Reader/OpenApiConvertSettings.cs

Line 334 in 087438b

public bool UseStringArrayForQueryOptionsSchema { get; set; } = true;

Added in #499

Setting the default to true effectively changed every conversion from emitting array of enum values to arrays of strings silently.
This is a strong behaviour change, and the default should have been false.
@baywet baywet added priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days type:bug A broken experience type:regression A bug from previous release labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:p1 High priority but not blocking. Causes major but not critical loss of functionality SLA <=7days type:bug A broken experience type:regression A bug from previous release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baywet