Skip to content

Commit 1ad4ede

Browse files
committed
chore: refactoring
Signed-off-by: Vincent Biret <vibiret@microsoft.com>
1 parent 39a9f41 commit 1ad4ede

File tree

1 file changed

+11
-18
lines changed

1 file changed

+11
-18
lines changed

test/Microsoft.OpenApi.Readers.Tests/YamlConverterTests.cs

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -209,10 +209,7 @@ public void ToYamlNode_StringWithLineBreaks_PreservesLineBreaks()
209209
var yamlOutput = ConvertYamlNodeToString(yamlNode);
210210

211211
// Convert back to JSON to verify round-tripping
212-
var yamlStream = new YamlStream();
213-
using var sr = new StringReader(yamlOutput);
214-
yamlStream.Load(sr);
215-
var jsonBack = yamlStream.Documents[0].ToJsonNode();
212+
var jsonBack = ConvertYamlStringToJsonNode(yamlOutput);
216213

217214
// Assert - line breaks should be preserved during round-trip
218215
var originalMultiline = json["multiline"]?.GetValue<string>();
@@ -260,13 +257,7 @@ public void NumericPropertyNamesShouldRemainStringsFromYaml()
260257
"456": value2
261258
""";
262259

263-
var yamlDocument = new YamlStream();
264-
using var sr = new StringReader(yamlInput);
265-
yamlDocument.Load(sr);
266-
var yamlRoot = yamlDocument.Documents[0].RootNode;
267-
// When
268-
269-
var jsonNode = yamlRoot.ToJsonNode();
260+
var jsonNode = ConvertYamlStringToJsonNode(yamlInput);
270261

271262
var convertedBack = jsonNode.ToYamlNode();
272263
var convertedBackOutput = ConvertYamlNodeToString(convertedBack);
@@ -284,19 +275,21 @@ public void BooleanPropertyNamesShouldRemainStringsFromYaml()
284275
"false": value2
285276
""";
286277

287-
var yamlDocument = new YamlStream();
288-
using var sr = new StringReader(yamlInput);
289-
yamlDocument.Load(sr);
290-
var yamlRoot = yamlDocument.Documents[0].RootNode;
291-
// When
292-
293-
var jsonNode = yamlRoot.ToJsonNode();
278+
var jsonNode = ConvertYamlStringToJsonNode(yamlInput);
294279

295280
var convertedBack = jsonNode.ToYamlNode();
296281
var convertedBackOutput = ConvertYamlNodeToString(convertedBack);
297282
// Then
298283
Assert.Equal(yamlInput.MakeLineBreaksEnvironmentNeutral(), convertedBackOutput.MakeLineBreaksEnvironmentNeutral());
299284
}
285+
private static JsonNode ConvertYamlStringToJsonNode(string yamlInput)
286+
{
287+
var yamlDocument = new YamlStream();
288+
using var sr = new StringReader(yamlInput);
289+
yamlDocument.Load(sr);
290+
var yamlRoot = yamlDocument.Documents[0].RootNode;
291+
return yamlRoot.ToJsonNode();
292+
}
300293

301294
private static string ConvertYamlNodeToString(YamlNode yamlNode)
302295
{

0 commit comments

Comments
 (0)