Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] pnpm support #1150

Closed
lwyj123 opened this issue Nov 7, 2021 · 6 comments
Closed

[Feature] pnpm support #1150

lwyj123 opened this issue Nov 7, 2021 · 6 comments

Comments

@lwyj123
Copy link

lwyj123 commented Nov 7, 2021

Feature Request

I found the nodejs build document but didn't find pnpm support. now I use PRE_BUILD_COMMAND and CUSTOM_BUILD_COMMAND for this but it's good that Oryx could have official support like yarn and lerna

@jechtom
Copy link

jechtom commented Jan 2, 2022

As @lwyj123 wrote you can workaround this with extending github action step Azure/static-web-apps-deploy@v1 yaml with env variables:

        env:
          PRE_BUILD_COMMAND: npm install -g pnpm
          CUSTOM_BUILD_COMMAND: pnpm install && pnpm run build

@Nickhoyer
Copy link

I seem to be having issues with this workaround in a bitbucket pipeline due to the pnpm cache.

EACCES  EACCES: permission denied, mkdir '/opt/atlassian/pipelines/agent/build/.pnpm-store/v3'

Hoping it can get some attention

@itpropro
Copy link

itpropro commented Feb 5, 2023

Any updates here? Many OSS projects switched to PNPM and Oryx should have native support for detecting and using it.

@simonjj
Copy link

simonjj commented Jan 11, 2024

We're not currently looking to support pnpm. Closing this issue for now, please create a new issue and link to this one if you feel strongly.

@simonjj simonjj closed this as not planned Won't fix, can't repro, duplicate, stale Jan 11, 2024
@itpropro
Copy link

itpropro commented Jan 12, 2024

We're not currently looking to support pnpm. Closing this issue for now, please create a new issue and link to this one if you feel strongly.

That is really unfortunate as it means that Oryx cannot be used for the majority of modern JS/TS projects. I appreciate the feedback anyway, as we have now a clear position and can look for alternatives.

Are there any plans to remove the dependencies of some of the Azure related GitHub actions (App Service, Azure Functions and Static Web Apps for example) on Oryx, so they are not blocking users from using the services with their applications that use pnpm @simonjj ?

@danielroe
Copy link

Would it be possible instead to use corepack (& corepack enable) so that node could detect and use whatever package manager is supported by the project? That would also offload the job of detecting/installing the appropriate version of package managers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants