Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for repl hang when using with pyzmq => 18.0.0 #5252

Merged
merged 2 commits into from
Apr 23, 2019
Merged

fix for repl hang when using with pyzmq => 18.0.0 #5252

merged 2 commits into from
Apr 23, 2019

Conversation

bschnurr
Copy link
Member

  • Both execute(..) and get_shell_msg(..) act on the same shell socket and having a blocking call to get_shell_msg(..) no longer works with the newer pyzmq.
  • temporary fix was to downgrade pyzmq to 17.1.3
  • Changed get_shell_msg(..) to use a timeout instead of blocking.

related to bug #5233

@bschnurr
fix for repl hang when using with pyzmq => 18.0.0
9cefd3a 
- Both execute(..) and get_shell_msg(..) act on the same shell socket and having a blocking call to get_shell_msg(..) no longer works with the newer pyzmq.
- temporary fix was to downgrade pyzmq to 17.1.3
- Changed get_shell_msg(..) to use a timeout instead of blocking.

related to bug  #5233
@bschnurr bschnurr merged commit a9266fc into master Apr 23, 2019
@bschnurr bschnurr deleted the bschnurr/fix_repl_hang branch April 23, 2019 22:23
@bschnurr
Copy link
Member Author

jupyter/jupyter_client#436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huguesv huguesv huguesv approved these changes

Assignees

@huguesv huguesv

@RaymonGulati1 RaymonGulati1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bschnurr @huguesv @RaymonGulati1