Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo breaking change: Add ParserOptions default ctor #1318

Closed
MikeStall opened this issue Apr 5, 2023 · 0 comments · Fixed by #1320
Closed

undo breaking change: Add ParserOptions default ctor #1318

MikeStall opened this issue Apr 5, 2023 · 0 comments · Fixed by #1320
Assignees
Milestone

Comments

@MikeStall
Copy link
Contributor

MikeStall commented Apr 5, 2023

Public default ctor for ParserOptions was wrongfully removed in #1292.
(see #1292 (comment). )

This is a breaking change and is causing other dlls to now throw:
System.MissingMethodException: 'Method not found: 'Void Microsoft.PowerFx.ParserOptions..ctor()'.'

According to the .net loader:

  • A default ctor means no parameters.
  • Whereas a default parameter is a compiler-level construct (the compiler will insert the default value at the callsite), but it's still a regular parameter for .net loader.

At least one occurence:

 	Microsoft.ProgramSynthesis.Repair.PowerFx.Context.EngineContext.EngineContext(Microsoft.PowerFx.Engine engine, Microsoft.PowerFx.ReadOnlySymbolTable globalSymboilTable, Microsoft.PowerFx.Types.FormulaType expectedType, bool isBehavior, bool checkExpectedType)	Unknown
 	Microsoft.ProgramSynthesis.Repair.PowerFx.RepairHandler.SuggestFixesAsync(Microsoft.PowerFx.Engine engine, Microsoft.PowerFx.CheckResult result, System.Threading.CancellationToken cancel)	Unknown


@MikeStall MikeStall added this to the GA 1.0 milestone Apr 5, 2023
@MikeStall MikeStall changed the title Add ParserOptions default ctor undo breaking change: Add ParserOptions default ctor Apr 5, 2023
@LucGenetier LucGenetier linked a pull request Apr 6, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants