Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PowerToys Run] Upgrade .NET Core 3.1 to .NET 5 #12285

Closed
mykhailopylyp opened this issue Jul 8, 2021 · 7 comments
Closed

[PowerToys Run] Upgrade .NET Core 3.1 to .NET 5 #12285

mykhailopylyp opened this issue Jul 8, 2021 · 7 comments
Labels
Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window

Comments

@mykhailopylyp
Copy link
Contributor

mykhailopylyp commented Jul 8, 2021

Description of the new feature / enhancement

Upgrade PowerLauncher and all plugins to .NET 6

PowerToys Run and some plugins use Windows Runtime. It is not available in .NET 5 as before but can still be used with Target Framework Moniker option. With this option we have to specify the version of windows runtime. It should be windows10.0.18362.0 as it is the lowest version of windows we support. We should explorer other options here as well.

There is a bunch of obsolete APIs that should be replaced:

  • Assembly.GlobalAssemblyCache. It is used in exception formatted to show loaded assemblies. Should be easy to fix
  • Microsoft.Toolkit.Uwp.Notifications.NotificationActivator. It is used for toast notifications
  • Microsoft.Toolkit.Uwp.Notifications.DesktopNotificationManagerCompat. It is used for toast notifications
  • System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
@mykhailopylyp mykhailopylyp added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Jul 8, 2021
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jul 8, 2021
@mykhailopylyp
Copy link
Contributor Author

Parent issue is #8650

@mykhailopylyp mykhailopylyp removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jul 8, 2021
@mykhailopylyp mykhailopylyp self-assigned this Jul 12, 2021
@mykhailopylyp mykhailopylyp added the Status-In progress This issue or work-item is under development label Jul 12, 2021
@mykhailopylyp mykhailopylyp removed the Status-In progress This issue or work-item is under development label Jul 28, 2021
@davidegiacometti
Copy link
Collaborator

davidegiacometti commented Jul 29, 2021

@mykhailopylyp
with Microsoft.Toolkit.Uwp.Notifications removed registry key can also be removed.

<RegistryKey Root="HKLM" Key="SOFTWARE\Classes\AppUserModelId\PowerToysRun">

Reference: https://docs.microsoft.com/en-us/windows/apps/design/shell/tiles-and-notifications/send-local-toast?tabs=desktop#step-4-handling-uninstallation

@dedavis6797
Copy link
Contributor

dedavis6797 commented Oct 28, 2021

@DHowett shouldn't we be in a good state to get this done next release with the build pipeline migration just about wrapped up?

@DHowett
Copy link
Member

DHowett commented Oct 29, 2021

Yeah.

@crutkas crutkas changed the title [PowerToys Run] Upgrade .NET Core 3.1 to .NET 5 [PowerToys Run] Upgrade .NET Core 3.1 to .NET 6 Nov 22, 2021
@crutkas
Copy link
Member

crutkas commented Nov 30, 2021

This needs the new pipeline work before we can migrate so moving to 0.55

@crutkas crutkas added Priority-1 Bug that is high priority and removed Status-Blocked We can't make progress due to a dependency or issue labels Dec 27, 2021
@crutkas
Copy link
Member

crutkas commented Jan 21, 2022

@stefansjfw is this work done with the .net 5 upgrade?

@crutkas crutkas changed the title [PowerToys Run] Upgrade .NET Core 3.1 to .NET 6 [PowerToys Run] Upgrade .NET Core 3.1 to .NET 5 Jan 21, 2022
@stefansjfw
Copy link
Collaborator

@crutkas yes

@crutkas crutkas closed this as completed Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority-1 Bug that is high priority Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Projects
None yet
Development

No branches or pull requests

6 participants