Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Keyboard Manager] Add an option for remapped keys to return to default when a modifier key is pressed #13480

Open
JacksonCampbell99 opened this issue Sep 28, 2021 · 10 comments
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager

Comments

@JacksonCampbell99
Copy link

Description of the new feature / enhancement

When keys have been remapped, it throws off remapped shortcuts that use those keys. For example, if you remap S to D and D to S, when clicked they oddly enough do not remap in an infinite loop to each other, but they do remap all associated shortcuts ("save" becomes physical keys Ctl+D). Another example, if I have VolDown mapped to Mute and want Alt+VolDown to do VolUp, then I would have to change the remapped shortcut to Alt+Mute. It creates a big mess because a simple key remapping changes common default shortcuts (like the above illustration, "save" turns into Ctl+D) meaning simple shortcuts have to be remapped to stay default from key changes, and then custom remapped shortcuts don't work because the keys they use are remapped, so you have to remap your remapped shortcuts to the included remapped keys.

Scenario when this would be used?

Beyond the illustrations given above, I run into issues with this scenario because I want to remap PrtScn to be Win+Shift+S [Screen Snip] and Win+PrtScn to be PrtScn [Screenshot]. Because remapped shortcuts act on the remapping of the key involved, when I press Win+PrtScn, Windows receives Win+{Win+Shift+S}. Trying to bypass this creates another problem because a shortcut cannot contain more than two modifiers/3 keys, so I couldn't even create my PrtScn shortcut since Win+Win+Shift+S is not allowed. But that wouldn't work anyway because the key that whole thing is remapped to is PrtScn making it again output Win+Shift+S [Screen Snip]. So, the only way to solve these problems is if there is an option to disable key remappings (or return remapped keys to default) when a modifier key is pressed so that I could have PrtScn remapped AND be able to remap Win+PrtScn without running into a problem. This would also fix problems with nonremapped shortcuts unintentionally changing like Ctl+S in the case of S being remapped.

Read about the whole thing in the issue and comments over at #13341 to see get more insight and see how other default shortcuts like Alt+PrtScn are affected in the whole mess.

Supporting information

I laid my issues out in #13341 thinking that it was a bug when it is just the normal behavior.

@JacksonCampbell99 JacksonCampbell99 added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Sep 28, 2021
@JacksonCampbell99
Copy link
Author

@crutkas
Copy link
Member

crutkas commented Oct 2, 2021

This is a neat idea. I like it. Use case totally understandable as well.

@crutkas crutkas added Idea-Enhancement New feature or request on an existing product Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager Help Wanted We encourage anyone to jump in on these and submit a PR. and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Oct 2, 2021
@crutkas crutkas added this to the Post stabilization milestone Oct 2, 2021
@JacksonCampbell99
Copy link
Author

JacksonCampbell99 commented Nov 2, 2021

@ChoiYunseok98 Neither one of those options made sense. (If option 2 is an implementation that would add using an additional key to make the shortcut go default, it would basically defeat the point of the feature and use case.) Are they options for an implementation of my feature or an addition? Could you explain them a little more?

@crutkas
Copy link
Member

crutkas commented Nov 2, 2021

@JacksonCampbell99 just to reiterate here what the ask here is.

if I remap S key to A, and want to do Ctrl-S to save a file, the Ctrl-S should work saving the file instead of sending a Ctrl-A

Is that correct? basically if it isn't a direct map 1:1 remap, don't do it the key remapping.

@JacksonCampbell99
Copy link
Author

@crutkas Exactly. While that example may not be the ordinary use case, the use case would affect every remap I've been hoping to use to boost productivity.

@ChoiYunseok98
Copy link

Sorry I misunderstood.
Comments have been deleted to avoid confusion. X(

@crutkas
Copy link
Member

crutkas commented Nov 3, 2021

@ChoiYunseok98 what did you think it was again?

@ChoiYunseok98
Copy link

@crutkas I overlooked that this issue is the content of the "keyboard manager". I wrote what I thought as an issue. #14268

@altimmons
Copy link

I need this. I remap CapsLock because I hate it. But sometimes capslock in inexplicably pressed and enabled. And now I cant disable capslock.

I would also love the ability to map hardware key + Modifier, e.g. Ctrl + Caps Lock

@JacksonCampbell99
Copy link
Author

Absolutely need these things. Too bad that other guy couldn't work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We encourage anyone to jump in on these and submit a PR. Idea-Enhancement New feature or request on an existing product Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager
Projects
Status: No status
Development

No branches or pull requests

4 participants