Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VideoConferenceMute] VCM do not respect Windows DPI scaling #14079

Closed
1 task done
franky920920 opened this issue Oct 29, 2021 · 24 comments
Closed
1 task done

[VideoConferenceMute] VCM do not respect Windows DPI scaling #14079

franky920920 opened this issue Oct 29, 2021 · 24 comments
Assignees
Labels
Area-User Interface things that regard UX for PowerToys Issue-Bug Something isn't working Product-Video Conference Mute Refers to the Video Conference muting tool Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@franky920920
Copy link
Contributor

franky920920 commented Oct 29, 2021

Microsoft PowerToys version

0.49.0

Running as admin

  • Yes

Area(s) with issue?

Video Conference Mute

Steps to reproduce

As @void-mian, @gleib says in #13221 (comment), VCM does not respect Windows DPI scale.

✔️ Expected Behavior

VCM respects the DPI scale.

❌ Actual Behavior

VCM does not respect the DPI scale. Become too small in high-resolution monitors.

Other Software

No response

@franky920920 franky920920 added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Product-Video Conference Mute Refers to the Video Conference muting tool labels Oct 29, 2021
@ckempo
Copy link

ckempo commented Nov 1, 2021

Can confirm - the VCM control is very tiny in comparison:

image

@franky920920
Copy link
Contributor Author

Seems like what's happening in #13221.
Should implement this as a #hotfix if there is a v0.49.2.

@franky920920
Copy link
Contributor Author

cc: @jaimecbernardo

@jaimecbernardo
Copy link
Collaborator

This is raw win32.
It's not an easy fix, unless we disable dpi awareness for it and accept the blurriness from the OS auto-scaling.
Ideally, this would be ported to WinUI3 when it's out for win32 apps.

@jaimecbernardo
Copy link
Collaborator

@yuyoyuppe , That's accurate, right?

@jaimecbernardo
Copy link
Collaborator

Perhaps the blurriness would be better if it's this small.

@franky920920
Copy link
Contributor Author

I would say that blurriness will be ok for VCM's toolbar for me.

@yuyoyuppe
Copy link
Contributor

yuyoyuppe commented Nov 2, 2021

@jaimecbernardo that sounds accurate!

@yuyoyuppe
Copy link
Contributor

It might be simple to move it to a separate thread from the runner (which is dpi aware) and disable dpi awareness for that thread and run a message loop from there.

@yuyoyuppe yuyoyuppe self-assigned this Nov 2, 2021
@yuyoyuppe
Copy link
Contributor

In the long run, we'll port VCM UI to .svg/winui 3.

@yuyoyuppe
Copy link
Contributor

yuyoyuppe commented Nov 2, 2021

also see related #6246 (comment)

@larsschellhas
Copy link

I was really worried about that small window popping up on my screen without me knowing what it actually was :'D
image

@Moaske
Copy link

Moaske commented Mar 31, 2022

I see this issue is still open.... 😊 (VCM nog respecting high DPI scaling)

image

@ThatOtherAndrew
Copy link

Same issue here - some sort of way to adjust scaling would be a godsend.

@bjason
Copy link

bjason commented Jul 8, 2022

It has been 9 months since it was first reported and most of the components have transferred to WinUI3. Any update on this issue?

@ChungZH
Copy link

ChungZH commented Jul 29, 2022

so....? When will this problem be solved?

@Juraj2
Copy link

Juraj2 commented Sep 28, 2022

Confirm this is still an issue:
On Windows monitor resolution 3840x2400 at Scale 225%:
image

The toolbar is too small almost not readable:
image

while on resolution 1920x1080 at Scale 100% it is ok to read:
image

@crutkas
Copy link
Member

crutkas commented Dec 28, 2022

Thanks for the feedback but VCM is moving to maintenance only in the 0.67 timeframe. Our team will only directly address critical bugs, security and accessibility issues.

We'll accept community PRs for enhancements.

@crutkas crutkas closed this as completed Dec 28, 2022
@mshish
Copy link

mshish commented Dec 30, 2022

This is an accessibility issue... @crutkas

@mshish
Copy link

mshish commented Feb 2, 2023

@crutkas what's the right way to get this properly classified as the accessibility issue that it is?

@jaimecbernardo jaimecbernardo self-assigned this Mar 1, 2023
@jaimecbernardo jaimecbernardo reopened this Mar 1, 2023
@jaimecbernardo jaimecbernardo added Status-In progress This issue or work-item is under development and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Mar 1, 2023
@jaimecbernardo
Copy link
Collaborator

Reopening and handling this.

@kjellerstedt
Copy link

Reopening and handling this.

Sorry for borrowing the thread but could this be the cause of issue that makes the VCM overlay not staying in the selected position when changing monitors/dpi scaling?

@Jay-o-Way Jay-o-Way added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Mar 27, 2023
@Jay-o-Way Jay-o-Way moved this from In Progress ⚒️ to Done ✔ in Test for PowerToys Mar 27, 2023
@gleib
Copy link

gleib commented Apr 7, 2023

Confirming this is fixed for me. Thx much!

@crutkas
Copy link
Member

crutkas commented May 8, 2023

Fixed in 0.69 which was released in the start of April 2023.

@crutkas crutkas closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface things that regard UX for PowerToys Issue-Bug Something isn't working Product-Video Conference Mute Refers to the Video Conference muting tool Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
Status: Done
Development

No branches or pull requests