crash after I click PowerRename

[Gowntn]

Microsoft PowerToys version

0.49.1

Running as admin

• Yes

Area(s) with issue?

PowerRename

Steps to reproduce

I use PowerRename to rename some files and it will crash after I click anywhere，by the way I use Simplified Chinese system

✔️ Expected Behavior

No response

❌ Actual Behavior

crash after I click PowerRename

Other Software

No response

[franky920920]

Could you attach a full bug report file?
Right-click on the tray icon and click Report Bug. Then drag-and-drop the generated file into the GitHub comment to upload it. Thanks!

cc: @stefansjfw Maybe #14076?

[stefansjfw]

@franky920920 Don't think it's #14076, it wouldn't open at all.. Might be resolution related issue

[Toastie]

I am observing the same issue, altough my Windows language is set to German so that is not the problem. Furthermore, I do not need to click anywhere for the tool to crash, the window simply closes about 0.5 to 1 sec after opening.

One thing I noticed is that this only seems to occur if a subset of all files (or even a single file) in a folder is selected. If everything is selected PowerRename works fine.

I have attached a report produced right after observing the issue.
PowerToysReport_2021-11-10-12-07-46.zip

[gogefo]

Same behaviour at my machine. Unlike Toastie, it also happens when everything is selected.

Also attaching report below
PowerToysReport_2021-11-10-18-12-45.zip

[htcfreek]

@Toastie , @gogefo
Do you have more than one monitor?

[Toastie]

On my laptop, where this issue occurred, no. It seems to work most of the time on my dekstop (which has 3 monitors), although it will rarely crash there too.

[gogefo]

No, only had my laptop to test.

[HyperNuke632]

The issue seems to be if the scale and layout are not set to 100% in Windows' display settings. (I use 125%.)

[htcfreek]

The issue seems to be if the scale and layout are not set to 100% in Windows' display settings. (I use 125%.)

Great. I am sure you got it.

@stefansjfw, can you look into this scaling/monitor setup bugs. Would be great if we can fix this with 0.51.

[StephanSchue]

Yes, it is the scaling of the monitor for me. Using a Laptop Monitor on 125% scale.

[HashedSage]

same issue for me too ref: #14440
closed my issue, seeming its already been reported, have uploaded a report in #14440

[stefansjfw]

Looking into it...

[crutkas]

If this is DPI related, this will be a common crash. @jaimecbernardo adding to 0.51

[htcfreek]

Yes, it is the scaling of the monitor for me. Using a Laptop Monitor on 125% scale.

@StephanSchue
Which display resolution do you have? Can you please try it with 1600x900 and 125%.

See also: #14180 (comment)

[StephanSchue]

Seems to work. But wouldn't be a solution for me.

[htcfreek]

Seems to work. But wouldn't be a solution for me.

Sure. But now we can understand it better.

@crutkas , @stefansjfw
Here some points to know:

1. The window is open on main monitor every time!
2. The monitor resolution can't be higher than 1600x900 with 125% or 1920x1080 with 100%.

[htcfreek]

Seems to work. But wouldn't be a solution for me.

@StephanSchue
Can you please do a ladt try: 1600x900 with 150%

[stefansjfw]

I'm not able to reproduce this crash. Trying for some time now with all kind of different combinations of resolution and dpi.

The monitor resolution can't be higher than 1600x900 with 125% or 1920x1080 with 100%.

I am developing and using new PowerRename constantly with 2560x1600, 150% scaling and haven't experienced this crash ever. So it must be something else included as well. I'll keep trying

[crutkas]

Are we sure they are the same issue?

[htcfreek]

Are we sure they are the same issue?

Not 100% because for me only PowerRename is crashing. Terminal and PT Settings (see external issue) doesn't.

[stefansjfw]

@htcfreek Can you try building latest main and running PowerRenameUIHost project directly to see if it fails that way? I managed to reproduce it few times with 49.1, but not on latest main.. So it would be good if you could try as I understood you can reproduce it 100% time

[htcfreek]

@stefansjfw
Let me look into this tomorrow/wednesday. 😉

Should be possible to compile it on a net share in my vm and run it from the net share on my productive host. Is it? (Because it only craahes on my host system 100% of the time. 🤨)

[stefansjfw]

I can create a custom PT build for you if want? So you can just install it and try..

[htcfreek]

I can create a custom PT build for you if want? So you can just install it and try..

Would be great

[stefansjfw]

@htcfreek Can you pass me an emails so I could send you the build?

[htcfreek]

@htcfreek Can you pass me an emails so I could send you the build?

Can you ask @crutkas on a private conversation. He has my email address.

[htcfreek]

@stefansjfw
Tried to build the solution based on main. In the first try it hangs and the second try failed.

Severity	Code	Description	Project	File	Line	Suppression State
Warning		The referenced component 'C:\Users\Heiko\.nuget\packages\microsoft.toolkit.win32.ui.xamlapplication\6.1.3\build\..\lib\uap10.0\Microsoft.Toolkit.Win32.UI.XamlHost.winmd' could not be found.	Microsoft.PowerToys.Settings.UI			
Error	C1041	cannot open program database 'N:\PT-M\x64\Debug\obj\powerpreview\vc142.pdb'; if multiple CL.EXE write to the same .PDB file, please use /FS	powerpreview	N:\PT-M\src\modules\previewpane\powerpreview\dllmain.cpp	1	
Error	C1041	cannot open program database 'N:\PT-M\x64\Debug\obj\powerpreview\vc142.pdb'; if multiple CL.EXE write to the same .PDB file, please use /FS	powerpreview	N:\PT-M\src\modules\previewpane\powerpreview\powerpreview.cpp	1	
Error	C1041	cannot open program database 'N:\PT-M\x64\Debug\obj\powerpreview\vc142.pdb'; if multiple CL.EXE write to the same .PDB file, please use /FS	powerpreview	N:\PT-M\src\modules\previewpane\powerpreview\trace.cpp	1	
Error	C1041	cannot open program database 'N:\PT-M\x64\Debug\obj\ColorPicker\vc142.pdb'; if multiple CL.EXE write to the same .PDB file, please use /FS	ColorPicker (modules\colorpicker\ColorPicker)	N:\PT-M\src\modules\colorPicker\ColorPicker\dllmain.cpp	2	
Warning	81010002	Unrecognized Element "maxversiontested" in namespace "urn:schemas-microsoft-com:compatibility.v1".	runner	N:\PT-M\src\runner\PowerToys.exe.manifest	1	
Warning	81010002	Unrecognized Element "maxversiontested" in namespace "urn:schemas-microsoft-com:compatibility.v1".	KeyboardManagerEditor	N:\PT-M\src\modules\keyboardmanager\KeyboardManagerEditor\KeyboardManagerEditor.exe.manifest	1	
Error	MSB3073	The command ""N:\PT-M\packages\Microsoft.Windows.CppWinRT.2.0.200729.8\build\native\..\..\bin\"cppwinrt @"N:\PT-M\x64\Debug\obj\PowerRenameUIHost\cppwinrt_ref.rsp"" exited with code 1.	PowerRenameUIHost	N:\PT-M\packages\Microsoft.Windows.CppWinRT.2.0.200729.8\build\native\Microsoft.Windows.CppWinRT.targets	544	

[htcfreek]

@stefansjfw
Stupid question: Is there a relation between monitor setup and number of items in the list view? If I have the extended setup it crashes 100% all the time if I don't have more than 11 items (folders and files) on the list view. (Tested with 0.49.1!)

[htcfreek]

@Toastie , @gogefo, @StephanSchue
Can you please try it with more than eleven files (or subfolder with eleven files) selected in explorer.

[Toastie]

More than 11 works fine, with 11 and below it crashes. @htcfreek

[htcfreek]

More than 11 works fine, with 11 and below it crashes.

@Toastie
Does it works with less than 12 when you use the resolution 1600x900, 150%?

(For me it does.)

[Toastie]

@htcfreek

Yep, it works with less than 11 files at that resolution and scaling.

[StephanSchue]

It crashs for me all the time. No matter how many files.

[htcfreek]

@stefansjfw
Fyi I got your e-mail and will test it within the next few days.

[htcfreek]

@stefansjfw
I don't know what you changed in code. But it works like a charm. Amazing. No crashes anymore.

(Same for the resizing crash in #14180.)

I suggest to cherry-pick the fix for a 0.53.1 release, if it's not part of 0.53.0! (cc: @crutkas)

[htcfreek]

[Off topic]
@stefansjfw, is it correct that dev builds aren't translated?

[stefansjfw]

@htcfreek glad to hear that! Thanks for testing! This is fixed by combination of 2 fixes merged recently. This should be in for next upcoming release. @crutkas
Let's not mark this as resolved yet. I would like to see if it's fixed for everyone first.

No, dev builds aren't translated.

[crutkas]

0.51 is out now, can we verify this is now fixed?

[HyperNuke632]

Seems to work just fine for me now.

[htcfreek]

For me it's fixed.