Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caps Lock indicator light malfunctions with Keyboard Manager #1692

Closed
arjunbalgovind opened this issue Mar 25, 2020 · 6 comments
Closed

Caps Lock indicator light malfunctions with Keyboard Manager #1692

arjunbalgovind opened this issue Mar 25, 2020 · 6 comments
Labels
Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager

Comments

@arjunbalgovind
Copy link
Contributor

Even if you suppress toggle keys (namely Caps Lock, Num Lock and Scroll Lock) with a low level hook the indicator light on the keyboard still gets toggled.

The following user-end problems can rise from this:
• A user swaps the Caps Lock key with his Tab key. Based on how the low level hook works, pressing the physical tab key (now internally Caps) seems to toggle the indicator light as expected (correct behavior). However clicking the physical Caps Lock key (which is now internally Tab) also toggles the indicator light (unexpected behavior), even though it does the action of Tab. This would basically mean the indicator light for Caps Lock might sometimes show “On” even though its Off or vice versa, hence confusing the user. This also applies to case where a user remaps a shortcut containing the Caps Lock key.
• At the detect key and detect shortcut window, when the user taps Caps Lock it will be detected correctly however the indicator light will toggle even though the actual functionality of the key has been suppressed.

There could be some hack-based way to fix this by re-sending Caps lock keydown messages so that the light gets toggled as per requirement.

@arjunbalgovind arjunbalgovind added the Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager label Mar 25, 2020
@crutkas crutkas added this to the v1.0 Release milestone Apr 14, 2020
@arjunbalgovind arjunbalgovind mentioned this issue May 15, 2020
3 tasks
@Szeraax
Copy link

Szeraax commented May 20, 2020

Confirmed with my 1903. Capslock functionality is remapping properly, but the keyboard light is still toggling when I press caps lock.

@erezsh
Copy link

erezsh commented Aug 14, 2020

Being able to swap the Esc & Caps keys would make me use this project. (Right now I'm using uncap, which is far from perfect too)

@arjunbalgovind
Copy link
Contributor Author

@erezsh while we don't currently support the dual remap feature (tracked at #5679 ), you should be able to swap Esc and Caps. Can you let us know what is the issue that you are facing?
image

@erezsh
Copy link

erezsh commented Aug 30, 2020

@arjunbalgovind Yes, it does work! Thanks, you just improved my Windows experience by a lot!

@Szeraax
Copy link

Szeraax commented Aug 31, 2020

Also been able to confirm that on my computer (which is now 1909) and latest PToys that the capslock light does NOT illuminate when I have remapped the capslock key to something else. Thanks @arjunbalgovind .This issue should be closed.

@crutkas
Copy link
Member

crutkas commented Dec 3, 2020

when using mapping above, caplocks toggles correctly

@crutkas crutkas closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-Keyboard Shortcut Manager Issues regarding Keyboard Shortcut Manager
Projects
None yet
Development

No branches or pull requests

4 participants