Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File Locksmith does not recognize files locked by the system user #21661

Closed
caiocinel opened this issue Nov 3, 2022 · 12 comments
Closed

File Locksmith does not recognize files locked by the system user #21661

caiocinel opened this issue Nov 3, 2022 · 12 comments
Assignees
@jaimecbernardo
Labels
Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-File Locksmith Refers to the File Locksmith utility Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@caiocinel
Copy link

Microsoft PowerToys version

0.64.0

Installation method

GitHub

Running as admin

Yes

Area(s) with issue?

File Locksmith

Steps to reproduce

With a Firebird 2.0 database classic server instance, just connect to a database file.

Image:
image

Bug Report:
PowerToysReport_2022-11-03-09-08-07.zip

✔️ Expected Behavior

The database file should be displayed as in use by the related process.

❌ Actual Behavior

No results are found

Other Software

Firebird 2.0
@caiocinel caiocinel added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 3, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Nov 3, 2022

@caiocinel
Did you run FLS with admin permission and what user is running the firebird service?

@jaimecbernardo
Copy link
Collaborator

Wonder if a /bugreport would help here to see if there's some error.

@ghost ghost added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 3, 2022
@ghost
Copy link

ghost commented Nov 3, 2022

Hi there!

We need a bit more information to really debug this issue. Can you add a "Report Bug" zip file here? You right click on our system tray icon and just go to report bug. Then drag the zipfile from your desktop onto the GitHub comment box in this issue. Thanks!
Report Bug

@caiocinel
Copy link
Author

caiocinel commented Nov 3, 2022 •
edited
Loading

@caiocinel Did you run FLS with admin permission and what user is running the firebird service?

I used the "Restart as Administrator" button from the utility itself, the server runs under the "SYSTEM" user

Wonder if a /bugreport would help here to see if there's some error.

PowerToysReport_2022-11-03-09-08-07.zip

@ghost ghost added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Nov 3, 2022
@htcfreek
Copy link
Collaborator

htcfreek commented Nov 3, 2022 •
edited
Loading

I can reproduce the bug. You can only see processes that have the same or a lower permission level. Even an administrator (uac) can't see processes running as system.

@jaimecbernardo , @ivanstosic-janea
What access permission do we use for query the process data?

@jaimecbernardo
Copy link
Collaborator

I believe we don't do too much with permissions here.
I see we have to use "SeDebugPrivilege" in order to get system or other processes information. I'll see what can be done here.

@jaimecbernardo
Copy link
Collaborator

I fixed it. Should probably get some UI warning in here for system processes, though.
image

@htcfreek
Copy link
Collaborator

htcfreek commented Nov 3, 2022

I fixed it. Should probably get some UI warning in here for system processes, though.
image

Do we request aknowledge on killing a process? If yes we cann add an additional sentence to war for system processes and my processes of other users too.

1 similar comment
@htcfreek
Copy link
Collaborator

htcfreek commented Nov 3, 2022

I fixed it. Should probably get some UI warning in here for system processes, though.
image

Do we request aknowledge on killing a process? If yes we cann add an additional sentence to war for system processes and my processes of other users too.

@jaimecbernardo
Copy link
Collaborator

Going with an icon with tooltip currently:
image

@jaimecbernardo jaimecbernardo mentioned this issue Nov 3, 2022
Merged
11 tasks
@jaimecbernardo
Copy link
Collaborator

Opened a PR with the fix: #21688

@jaimecbernardo jaimecbernardo self-assigned this Nov 3, 2022
@jaimecbernardo jaimecbernardo added Product-File Locksmith Refers to the File Locksmith utility Status-In progress This issue or work-item is under development and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Needs-Team-Response An issue author responded so the team needs to follow up labels Nov 3, 2022
@jaimecbernardo jaimecbernardo mentioned this issue Nov 5, 2022
Closed
@htcfreek htcfreek added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Nov 6, 2022
@jaimecbernardo jaimecbernardo mentioned this issue Nov 7, 2022
Closed
@jaimecbernardo jaimecbernardo changed the title File Locksmith does not recognize Firebird server databases File Locksmith does not recognize files locked by the system user Nov 7, 2022
@jaimecbernardo jaimecbernardo added the Hot Fix Items we will product an out-of-band release for label Nov 7, 2022
@jaimecbernardo
Copy link
Collaborator

Fixed in the latest version. Please update PowerToys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaimecbernardo jaimecbernardo

Labels
Hot Fix Items we will product an out-of-band release for Issue-Bug Something isn't working Product-File Locksmith Refers to the File Locksmith utility Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jaimecbernardo @caiocinel @htcfreek