-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PowerLauncher calculator should be customizable #3764
Comments
A normal dot (full stop) should not be used in stead of multiplication. In typing the asterisk * is normal and in writing you may use the middle•dot. There is already enough trouble with the locales: Using a comma or full stop as decimal point. Only valid comment is that the degree sign ° doesn't seem to be supported right now. |
The full stop for multiplication is used here in Vietnam, where you can see in all kinds of textbooks for students. We shouldn't need to go through the trouble of replacing dots with asterisks when for example, we copy-paste an expression. In case you missed, here is what I already said in implementation details:
It's in our own control to not rely on the computer's localization settings and format the numbers according to the app's settings chosen. To prevent inconvenience to the user, we can check for the computer's localization in the first run of the app and initialize the options based on that. |
For the comma as decimal separation, we have another issue tracking it (see #3367) |
I think a good thing we need to do here is come up with a ton of unit tests that handle appropriate regional preferences. Preferred route is adopting the calculator engine which should do this for us for free |
@leduyquang753 how does the windows calculator deal with this, does it handle your preferred options by default? |
It currently only handles the decimal separator customization, per Windows' localization settings. I have also opened an issue there to allow different forms of notation as well: microsoft/calculator#1251 |
Going to track this in #3367 |
Summary of the new feature/enhancement
Currently the calculator plugin only accepts expressions in the US format. For users using other formats (such as the comma for decimal separation and the dot for multiplication, yes the full stop), the calculator should provide necessary customization options.
Proposed technical implementation details
The text was updated successfully, but these errors were encountered: