Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache is not written if Powertoys run is not launched atleast once #4500

Closed
dsrivastavv opened this issue Jun 25, 2020 · 5 comments
Closed
Labels
Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Milestone

Comments

@dsrivastavv
Copy link
Contributor

No cache is written to disk on disabling Powertoys run if it is not launched atleast once.

@dsrivastavv dsrivastavv added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Jun 25, 2020
@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jun 25, 2020
@dsrivastavv
Copy link
Contributor Author

This issue is discussed in #4472.

@crutkas
Copy link
Member

crutkas commented Jun 26, 2020

is this a .20 fix?

@dsrivastavv
Copy link
Contributor Author

@crutkas I think we can fix it later as this doesn't have any user-facing consequences. No changes to the cache are made until the first launch.

@crutkas crutkas removed the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Jun 26, 2020
@crutkas crutkas added this to the v1.0 Release milestone Jun 26, 2020
@crutkas
Copy link
Member

crutkas commented Sep 1, 2020

@somil55 what is the ramifications of this work?

@crutkas crutkas modified the milestones: v1.0 Release, InVEST-2009 Sep 1, 2020
@dsrivastavv
Copy link
Contributor Author

@crutkas This would have left the cache in an invalid state if a program was modified. This is because the changes would not be written back and loaded in the next run. But since we are not using program cache anymore, there should not be any impact of this behavior.

@crutkas crutkas closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Projects
None yet
Development

No branches or pull requests

2 participants