Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored exception on ci in windows related to monitor and socket. #6099

Closed
jenshnielsen opened this issue May 21, 2024 · 1 comment · Fixed by #6107
Closed

Ignored exception on ci in windows related to monitor and socket. #6099

jenshnielsen opened this issue May 21, 2024 · 1 comment · Fixed by #6107

Comments

@jenshnielsen
Copy link
Collaborator

This may be related to the intermitted failures of monitor tests on windows

Observing the following traceback

Exception ignored in: <socket.socket fd=1116, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 55090), raddr=('127.0.0.1', 55091)>
Traceback (most recent call last):
  File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\threading.py", line 917, in run
    self._target(*self._args, **self._kwargs)
ResourceWarning: unclosed <socket.socket fd=1116, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 55090), raddr=('127.0.0.1', 55091)>
@jenshnielsen
Copy link
Collaborator Author

Had a look at the logs from running the tests and the websockets documentation. Its not clear that we are doing anything wrong. However unlike their examples we have to guard against connection closed errors within the async server function. It would probably make sense to use Open telemetry threading to see if we can understand better how the threads interact open-telemetry/opentelemetry-python-contrib#2253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant