This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
LocalUnivariateMinimum parameter range positive and negative problem #672
Labels
Kind-Enhancement
New feature or request
Status-NeedsApiReview
This PR requires an API review before merging in.
Positive and negative problems of the tolerance parameter in LocalUnivariateMinimum
Conceptual overview
Width(interval) > tolerance
is alwaystrue
.(item1,item2)
in argumentbounds
isitem1>item2
, the bool value ofWidth(interval) > tolerance
is alwaysfalse
, the program will not enter the search logic.Current status
mutable tolerance = -1.0;
The program will never finish executinglet bounds = (1.0, 0.1);
The program will never searchProposal
New and modified functions, operations, and UDTs
LocalUnivariateMinimum source code
QuantumLibraries/Standard/src/Optimization/Univariate.qs
Line 73 in 2214d89
Fact(tolerance > 0.0, "The tolerance value must be positive.");
LocalUnivariateMinimum Width source code
QuantumLibraries/Standard/src/Optimization/Univariate.qs
Line 28 in 2214d89
Fact(left <= right, "Left endpoint of bounds must be less than or equal to right endpoint.");
I hope I will be allowed to submit a pr as soon as possible because this logic problem is serious.
Code
The text was updated successfully, but these errors were encountered: