<random>: Fix several min/max values and gamma_distribution::param_type::operator== (#1601)

statementreply · web-flow · commit 481d1bdea20f · 2021-02-12T14:42:25.000-08:00
diff --git a/stl/inc/random b/stl/inc/random
@@ -2798,7 +2798,7 @@ public:
     }
 
     _NODISCARD result_type(max)() const { // get largest possible result
-        return (numeric_limits<result_type>::max)();
+        return numeric_limits<result_type>::infinity();
     }
 
     void reset() {} // clear internal state
@@ -2935,11 +2935,11 @@ public:
     }
 
     _NODISCARD result_type(min)() const { // get smallest possible result
-        return numeric_limits<result_type>::denorm_min();
+        return -numeric_limits<result_type>::infinity();
     }
 
     _NODISCARD result_type(max)() const { // get largest possible result
-        return (numeric_limits<result_type>::max)();
+        return numeric_limits<result_type>::infinity();
     }
 
     void reset() { // clear internal state
@@ -3075,7 +3075,7 @@ public:
         }
 
         _NODISCARD bool operator==(const param_type& _Right) const {
-            return _Px == _Right._Px;
+            return _Alpha == _Right._Alpha && _Beta == _Right._Beta;
         }
 
         _NODISCARD bool operator!=(const param_type& _Right) const {
@@ -3129,11 +3129,11 @@ public:
     }
 
     _NODISCARD result_type(min)() const { // get smallest possible result
-        return numeric_limits<result_type>::denorm_min();
+        return result_type{0.0};
     }
 
     _NODISCARD result_type(max)() const { // get largest possible result
-        return (numeric_limits<result_type>::max)();
+        return numeric_limits<result_type>::infinity();
     }
 
     void reset() {} // clear internal state
@@ -3324,7 +3324,7 @@ public:
     }
 
     _NODISCARD result_type(max)() const { // get largest possible result
-        return (numeric_limits<result_type>::max)();
+        return numeric_limits<result_type>::infinity();
     }
 
     void reset() {} // clear internal state
@@ -3456,11 +3456,11 @@ public:
     }
 
     _NODISCARD result_type(min)() const { // get smallest possible result
-        return (numeric_limits<result_type>::min)();
+        return -numeric_limits<result_type>::infinity();
     }
 
     _NODISCARD result_type(max)() const { // get largest possible result
-        return (numeric_limits<result_type>::max)();
+        return numeric_limits<result_type>::infinity();
     }
 
     void reset() {} // clear internal state
@@ -3594,11 +3594,11 @@ public:
     }
 
     _NODISCARD result_type(min)() const { // get smallest possible result
-        return -(numeric_limits<result_type>::max)();
+        return result_type{0.0};
     }
 
     _NODISCARD result_type(max)() const { // get largest possible result
-        return (numeric_limits<result_type>::max)();
+        return numeric_limits<result_type>::infinity();
     }
 
     void reset() {} // clear internal state
@@ -3720,11 +3720,11 @@ public:
     }
 
     _NODISCARD result_type(min)() const { // get smallest possible result
-        return numeric_limits<result_type>::denorm_min();
+        return result_type{0.0};
     }
 
     _NODISCARD result_type(max)() const { // get largest possible result
-        return (numeric_limits<result_type>::max)();
+        return numeric_limits<result_type>::infinity();
     }
 
     void reset() {} // clear internal state
@@ -3852,11 +3852,11 @@ public:
     }
 
     _NODISCARD result_type(min)() const { // get smallest possible result
-        return -(numeric_limits<result_type>::max)();
+        return -numeric_limits<result_type>::infinity();
     }
 
     _NODISCARD result_type(max)() const { // get largest possible result
-        return (numeric_limits<result_type>::max)();
+        return numeric_limits<result_type>::infinity();
     }
 
     void reset() {} // clear internal state
@@ -4053,7 +4053,7 @@ public:
     }
 
     _NODISCARD result_type(max)() const { // get largest possible result
-        return (numeric_limits<result_type>::max)();
+        return numeric_limits<result_type>::infinity();
     }
 
     void reset() {} // clear internal state
@@ -4186,11 +4186,11 @@ public:
     }
 
     _NODISCARD result_type(min)() const { // get smallest possible result
-        return -(numeric_limits<result_type>::max)();
+        return -numeric_limits<result_type>::infinity();
     }
 
     _NODISCARD result_type(max)() const { // get largest possible result
-        return (numeric_limits<result_type>::max)();
+        return numeric_limits<result_type>::infinity();
     }
 
     void reset() {} // clear internal state
diff --git a/tests/libcxx/expected_results.txt b/tests/libcxx/expected_results.txt
@@ -671,34 +671,16 @@ std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.geo/eval_param.pass.cpp
 std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.geo/eval.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.negbin/eval_param.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.cauchy/max.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.cauchy/min.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.chisq/max.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.chisq/min.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.f/max.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/eval_param.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/eval.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/max.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.lognormal/min.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.normal/max.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.normal/min.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.t/eval_param.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.t/eval.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.t/max.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.norm/rand.dist.norm.t/min.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.exp/max.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/eval_param.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/eval.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/max.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.extreme/min.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/eq.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/eval_param.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/eval.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/max.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.gamma/min.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.poisson/eval_param.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.poisson/eval.pass.cpp FAIL
-std/numerics/rand/rand.dis/rand.dist.pois/rand.dist.pois.weibull/max.pass.cpp FAIL
 std/numerics/rand/rand.dis/rand.dist.uni/rand.dist.uni.real/param_ctor.pass.cpp FAIL
 
 # Not yet analyzed, likely STL bugs. Various assertions.
diff --git a/tests/libcxx/skipped_tests.txt b/tests/libcxx/skipped_tests.txt
@@ -671,34 +671,16 @@ numerics\rand\rand.dis\rand.dist.bern\rand.dist.bern.geo\eval_param.pass.cpp
 numerics\rand\rand.dis\rand.dist.bern\rand.dist.bern.geo\eval.pass.cpp
 numerics\rand\rand.dis\rand.dist.bern\rand.dist.bern.negbin\eval_param.pass.cpp
 numerics\rand\rand.dis\rand.dist.bern\rand.dist.bern.negbin\eval.pass.cpp
-numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.cauchy\max.pass.cpp
-numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.cauchy\min.pass.cpp
-numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.chisq\max.pass.cpp
-numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.chisq\min.pass.cpp
-numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.f\max.pass.cpp
 numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.lognormal\eval_param.pass.cpp
 numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.lognormal\eval.pass.cpp
-numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.lognormal\max.pass.cpp
-numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.lognormal\min.pass.cpp
-numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.normal\max.pass.cpp
-numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.normal\min.pass.cpp
 numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.t\eval_param.pass.cpp
 numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.t\eval.pass.cpp
-numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.t\max.pass.cpp
-numerics\rand\rand.dis\rand.dist.norm\rand.dist.norm.t\min.pass.cpp
-numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.exp\max.pass.cpp
 numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.extreme\eval_param.pass.cpp
 numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.extreme\eval.pass.cpp
-numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.extreme\max.pass.cpp
-numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.extreme\min.pass.cpp
-numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.gamma\eq.pass.cpp
 numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.gamma\eval_param.pass.cpp
 numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.gamma\eval.pass.cpp
-numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.gamma\max.pass.cpp
-numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.gamma\min.pass.cpp
 numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.poisson\eval_param.pass.cpp
 numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.poisson\eval.pass.cpp
-numerics\rand\rand.dis\rand.dist.pois\rand.dist.pois.weibull\max.pass.cpp
 numerics\rand\rand.dis\rand.dist.uni\rand.dist.uni.real\param_ctor.pass.cpp
 
 # Not yet analyzed, likely STL bugs. Various assertions.

Original file line number	Diff line number	Diff line change
`@@ -2798,7 +2798,7 @@ public:`
`2798`	`2798`	`}`
`2799`	`2799`
`2800`	`2800`	`_NODISCARD result_type(max)() const { // get largest possible result`
`2801`		`- return (numeric_limits<result_type>::max)();`
	`2801`	`+ return numeric_limits<result_type>::infinity();`
`2802`	`2802`	`}`
`2803`	`2803`
`2804`	`2804`	`void reset() {} // clear internal state`
`@@ -2935,11 +2935,11 @@ public:`
`2935`	`2935`	`}`
`2936`	`2936`
`2937`	`2937`	`_NODISCARD result_type(min)() const { // get smallest possible result`
`2938`		`- return numeric_limits<result_type>::denorm_min();`
	`2938`	`+ return -numeric_limits<result_type>::infinity();`
`2939`	`2939`	`}`
`2940`	`2940`
`2941`	`2941`	`_NODISCARD result_type(max)() const { // get largest possible result`
`2942`		`- return (numeric_limits<result_type>::max)();`
	`2942`	`+ return numeric_limits<result_type>::infinity();`
`2943`	`2943`	`}`
`2944`	`2944`
`2945`	`2945`	`void reset() { // clear internal state`
`@@ -3075,7 +3075,7 @@ public:`
`3075`	`3075`	`}`
`3076`	`3076`
`3077`	`3077`	`_NODISCARD bool operator==(const param_type& _Right) const {`
`3078`		`- return _Px == _Right._Px;`
	`3078`	`+ return _Alpha == _Right._Alpha && _Beta == _Right._Beta;`
`3079`	`3079`	`}`
`3080`	`3080`
`3081`	`3081`	`_NODISCARD bool operator!=(const param_type& _Right) const {`
`@@ -3129,11 +3129,11 @@ public:`
`3129`	`3129`	`}`
`3130`	`3130`
`3131`	`3131`	`_NODISCARD result_type(min)() const { // get smallest possible result`
`3132`		`- return numeric_limits<result_type>::denorm_min();`
	`3132`	`+ return result_type{0.0};`
`3133`	`3133`	`}`
`3134`	`3134`
`3135`	`3135`	`_NODISCARD result_type(max)() const { // get largest possible result`
`3136`		`- return (numeric_limits<result_type>::max)();`
	`3136`	`+ return numeric_limits<result_type>::infinity();`
`3137`	`3137`	`}`
`3138`	`3138`
`3139`	`3139`	`void reset() {} // clear internal state`
`@@ -3324,7 +3324,7 @@ public:`
`3324`	`3324`	`}`
`3325`	`3325`
`3326`	`3326`	`_NODISCARD result_type(max)() const { // get largest possible result`
`3327`		`- return (numeric_limits<result_type>::max)();`
	`3327`	`+ return numeric_limits<result_type>::infinity();`
`3328`	`3328`	`}`
`3329`	`3329`
`3330`	`3330`	`void reset() {} // clear internal state`
`@@ -3456,11 +3456,11 @@ public:`
`3456`	`3456`	`}`
`3457`	`3457`
`3458`	`3458`	`_NODISCARD result_type(min)() const { // get smallest possible result`
`3459`		`- return (numeric_limits<result_type>::min)();`
	`3459`	`+ return -numeric_limits<result_type>::infinity();`
`3460`	`3460`	`}`
`3461`	`3461`
`3462`	`3462`	`_NODISCARD result_type(max)() const { // get largest possible result`
`3463`		`- return (numeric_limits<result_type>::max)();`
	`3463`	`+ return numeric_limits<result_type>::infinity();`
`3464`	`3464`	`}`
`3465`	`3465`
`3466`	`3466`	`void reset() {} // clear internal state`
`@@ -3594,11 +3594,11 @@ public:`
`3594`	`3594`	`}`
`3595`	`3595`
`3596`	`3596`	`_NODISCARD result_type(min)() const { // get smallest possible result`
`3597`		`- return -(numeric_limits<result_type>::max)();`
	`3597`	`+ return result_type{0.0};`
`3598`	`3598`	`}`
`3599`	`3599`
`3600`	`3600`	`_NODISCARD result_type(max)() const { // get largest possible result`
`3601`		`- return (numeric_limits<result_type>::max)();`
	`3601`	`+ return numeric_limits<result_type>::infinity();`
`3602`	`3602`	`}`
`3603`	`3603`
`3604`	`3604`	`void reset() {} // clear internal state`
`@@ -3720,11 +3720,11 @@ public:`
`3720`	`3720`	`}`
`3721`	`3721`
`3722`	`3722`	`_NODISCARD result_type(min)() const { // get smallest possible result`
`3723`		`- return numeric_limits<result_type>::denorm_min();`
	`3723`	`+ return result_type{0.0};`
`3724`	`3724`	`}`
`3725`	`3725`
`3726`	`3726`	`_NODISCARD result_type(max)() const { // get largest possible result`
`3727`		`- return (numeric_limits<result_type>::max)();`
	`3727`	`+ return numeric_limits<result_type>::infinity();`
`3728`	`3728`	`}`
`3729`	`3729`
`3730`	`3730`	`void reset() {} // clear internal state`
`@@ -3852,11 +3852,11 @@ public:`
`3852`	`3852`	`}`
`3853`	`3853`
`3854`	`3854`	`_NODISCARD result_type(min)() const { // get smallest possible result`
`3855`		`- return -(numeric_limits<result_type>::max)();`
	`3855`	`+ return -numeric_limits<result_type>::infinity();`
`3856`	`3856`	`}`
`3857`	`3857`
`3858`	`3858`	`_NODISCARD result_type(max)() const { // get largest possible result`
`3859`		`- return (numeric_limits<result_type>::max)();`
	`3859`	`+ return numeric_limits<result_type>::infinity();`
`3860`	`3860`	`}`
`3861`	`3861`
`3862`	`3862`	`void reset() {} // clear internal state`
`@@ -4053,7 +4053,7 @@ public:`
`4053`	`4053`	`}`
`4054`	`4054`
`4055`	`4055`	`_NODISCARD result_type(max)() const { // get largest possible result`
`4056`		`- return (numeric_limits<result_type>::max)();`
	`4056`	`+ return numeric_limits<result_type>::infinity();`
`4057`	`4057`	`}`
`4058`	`4058`
`4059`	`4059`	`void reset() {} // clear internal state`
`@@ -4186,11 +4186,11 @@ public:`
`4186`	`4186`	`}`
`4187`	`4187`
`4188`	`4188`	`_NODISCARD result_type(min)() const { // get smallest possible result`
`4189`		`- return -(numeric_limits<result_type>::max)();`
	`4189`	`+ return -numeric_limits<result_type>::infinity();`
`4190`	`4190`	`}`
`4191`	`4191`
`4192`	`4192`	`_NODISCARD result_type(max)() const { // get largest possible result`
`4193`		`- return (numeric_limits<result_type>::max)();`
	`4193`	`+ return numeric_limits<result_type>::infinity();`
`4194`	`4194`	`}`
`4195`	`4195`
`4196`	`4196`	`void reset() {} // clear internal state`