Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn/block building in wrong command prompt #4639

Closed
AlexGuteniev opened this issue Apr 28, 2024 · 1 comment · Fixed by #4709 or #4717
Closed

Warn/block building in wrong command prompt #4639

AlexGuteniev opened this issue Apr 28, 2024 · 1 comment · Fixed by #4709 or #4717
Labels
build Related to the build system fixed Something works now, yay!

Comments

@AlexGuteniev
Copy link
Contributor

I haven't encountered this myself yet but seen folks running into failed attempt of building x64 preset from x86 command prompt or the reverse.

Apparently, there's Platform environment variable set by these command prompts, which can easily identify the target arch type.

Think we can check this in CMake files and reject some futile attempts.
@AlexGuteniev
Copy link
Contributor Author

Some examples form Discord:
https://discord.com/channels/737189251069771789/740318951766098012/1232341468933259295
https://discord.com/channels/737189251069771789/832305953562427513/1186978705084530688
https://discord.com/channels/737189251069771789/956471101628768336/956471687648526358
(that's all I found quickly, but I didn't do an exhaustive search)

@StephanTLavavej StephanTLavavej added the build Related to the build system label May 1, 2024
This was referenced Jun 3, 2024
Merged
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Related to the build system fixed Something works now, yay!
Projects
None yet
Milestone
No milestone
2 participants
@AlexGuteniev @StephanTLavavej