Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5278 #5279

Closed
wants to merge 1 commit into from
Closed

Fix #5278 #5279

wants to merge 1 commit into from

Conversation

SainoNamkho
Copy link

@SainoNamkho SainoNamkho commented Feb 12, 2025

Fix #5278

@SainoNamkho SainoNamkho requested a review from a team as a code owner February 12, 2025 15:04
@SainoNamkho
Copy link
Author

@microsoft-github-policy-service agree

@davidmrdavid
Copy link
Member

Hi @SainoNamkho,

Thank you for your contribution 🌟 .
For any PR, please provide a thorough title and description beyond "fixes [bugID]". That helps us keep the git history clean and assists during future audits.

We observe that the PR is also failing the CI validation: failing to build. That would need to be fixed if this PR were to be merged. In the future, please ensure your change builds and relevant tests pass locally ✅ before opening a PR .

As mentioned in #5278, it's unclear to the maintainers if this change is needed according to the standard. For that reason, we'll be closing this PR but we are open to making changes in this code path after receiving guidance from the LWG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

<format>: charT for std::formatter<basic_string_view> is not supposed to be template parameter
2 participants