Add support for UseNavigationViewWhenPossible

[nmetulev]

For new Features:

• Overview: With the 2.1 update of the UWP Community Toolkit, the HamburgerMenu now support NavigationView. However, the WTS templates will need to be updated to ensure the HamburgerMenu will look great when using (and not using) the NavigationView

• Links:
  HamburgerMenu NavigationView documentation
  hamburger menu fluent design bug in version 2.1 CommunityToolkit/WindowsCommunityToolkit#1652

[mvegaca]

Working on it.

[mvegaca]

Hi @nmetulev
I'm updating the tookit to 2.1.0 version. In case of Hamburguer menu I've seen that if it's on FCU W10 appears a header text when the window is in narrow state.

This is a screenshot of toolkit sample app.

How can I customize this text or avoid this behavior?

[mvegaca]

Could it be the NavigationView header that it isn't set to a HamburguerMenu property?

[nmetulev]

It's a known issue actually, here is the fix: CommunityToolkit/WindowsCommunityToolkit#1655

[ralarcon]

@nmetulev Do you know when is planned to release this fix?

[nmetulev]

If you need this before February, we can do a 2.1.1 release to add this fix this month hopefully.

[crutkas]

@nmetulev we would need this before else it is a blocking issue.

[mvegaca]

I've been updating Toolkit version to 2.1.1 on this issue branch and adding conditional Xaml on window size change visual state changes.

I've found an app crash applying these changes to new Prism framework, It looks an unhandled exception when HamburgerControl sets the items source to NavigationView. I've been attached a crash repro here.

@nmetulev can have a look on this? I think the we are adding the same code on different frameworks and it still crashing on Prism. Thank you much!

[crutkas]

@LeeParrishMSFT actually you may need to take a look from @mvegaca's comment above regarding Prism

[mvegaca]

Code added on PR #1590. It's working on Prism.

[ralarcon]

It looks there was an issue with the target framework on prism project.

[crutkas]

what changed to make it fail then work?

[ralarcon]

The target framework was not set to 10.0.16299.0, that makes the NavView rise the exception...

[crutkas]

check, so repro had an issue, not the toolkit.

[LeeParrishMSFT]

I also ran into a similar issue in that when the version of the UWP Community Toolkit was updated to the later version that the target runtime in the base Prism project is too old. It was still set to 5.2.3, and the other projects have come up to 6.0.1.

I ran into this while working on issue #1548 and noticed it when I started bringing the UWP Toolkit into that template that it was forcing a downgrade of the Toolkit due to the old runtime version. So I'm going to move up the target framework for the base Prism project to 6.0.1, but I'll need to run all the unit tests again to verify it doesn't introduce any other issues. We can also set the target version to 10.0.16299.0 and get everything updated to the match the latest versions for Prism.

[ralarcon]

@LeeParrishMSFT We already have done these changes. They are in the dev branch right now.

[dgomezc]

Verified in Nightly
Wizard: 0.16.18015.65002
Templates: 0.16.18015.3