Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility for WPF #3459

Closed
7 tasks done
mvegaca opened this issue Dec 4, 2019 · 9 comments
Closed
7 tasks done

Accessibility for WPF #3459

mvegaca opened this issue Dec 4, 2019 · 9 comments
Assignees
@mvegaca
Labels
Accessibility Issue relates to accessibility in the wizard or a generated project. Can Close Out Soon Work relating to this issue has been completed. Generated Code Relates specifically to code contained in the generated project. WPF Relates to generated WPF projects
Milestone
3.9

Comments

@mvegaca
Copy link
Collaborator

mvegaca commented Dec 4, 2019 •
edited
Loading

We should fix these accessibility issues to be aligned with best practices and accessibility for WPF apps.

UI

Navigation

  • Add shortcuts for all commands.
  • Add accelerator keys en menus, submenus and add TODO comments to indicate to the developers that they should add accelerator keys to the pages.
@mvegaca mvegaca added in-progress The issue is currently being actively worked on. Generated Code Relates specifically to code contained in the generated project. Accessibility Issue relates to accessibility in the wizard or a generated project. WPF Relates to generated WPF projects labels Dec 4, 2019
@mvegaca mvegaca added this to the 3.6 milestone Dec 4, 2019
@mvegaca mvegaca self-assigned this Dec 4, 2019
@mvegaca mvegaca mentioned this issue Dec 12, 2019
Merged
@sibille sibille modified the milestones: 3.6, 3.7 Apr 22, 2020
@mvegaca mvegaca mentioned this issue Jun 4, 2020
Merged
@mvegaca mvegaca removed the in-progress The issue is currently being actively worked on. label Jun 4, 2020
@mrlacey
Copy link
Collaborator

mrlacey commented Jun 6, 2020

Did the guidelines mentioned above come from a public source/page? if so, can it be linked for reference?
Similarly, any reference documents for how to test this would be useful for future verification of templates.

@mvegaca
Copy link
Collaborator Author

mvegaca commented Jun 8, 2020

This is the doc for WPF Apps Accessibility best practices

@punker76
Copy link

@mvegaca @sibille Setting automation properties for hamburger menu (items, button) are coming in v2.1 PR

@sibille
Copy link
Collaborator

sibille commented Jun 19, 2020

Awesome, thanks! When is v2.1 shipping?

@mvegaca mvegaca mentioned this issue Jun 24, 2020
Merged
@sibille
Copy link
Collaborator

sibille commented Jun 29, 2020

Moving to 3.8 for the remaining work

@sibille sibille modified the milestones: 3.7, 3.8 Jun 29, 2020
@punker76
Copy link

punker76 commented Jul 3, 2020

@sibille @mvegaca This issue is now fixed and available with MahApps v2.1.1 and ControlzEx v4.3.1

High contrast (x-Ref MahApps/MahApps.Metro#3831).

@sibille
Copy link
Collaborator

sibille commented Jul 3, 2020

@punker76 awesome, thanks! We'll try it out.
One doubt: Do we still have to add our custom high contrast theme or are there plans to add a high contrast theme to MahApps?

@sibille sibille modified the milestones: 3.8, 3.9 Sep 21, 2020
@sibille
Copy link
Collaborator

sibille commented Nov 5, 2020

As MahApps/MahApps.Metro#3880 is fixed now, we're looking into adding High Contrast support to WPF templates.

Plan is to provide very basic HC themes, that the user has to complete with the colors and brushes used in the app. We'll add a developer TODO with links to the docs and theme templates provided by MahApps.

A mockup can be found at https://github.com/sibille/WTS.WPF.HighContrastSupport
We'll also add a "Windows default" option on the settings page which will set the theme the default theme configured in Windows.

@sibille sibille added the in-progress The issue is currently being actively worked on. label Nov 5, 2020
@mvegaca mvegaca mentioned this issue Nov 5, 2020
Merged
@sibille sibille added Can Close Out Soon Work relating to this issue has been completed. and removed in-progress The issue is currently being actively worked on. labels Nov 12, 2020
@sibille
Copy link
Collaborator

sibille commented Dec 1, 2020

Verified in dev-nighty version:
Templates version: 0.22.20336.2
Wizard version: 0.22.20336.1

@sibille sibille closed this as completed Dec 1, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mvegaca mvegaca

Labels
Accessibility Issue relates to accessibility in the wizard or a generated project. Can Close Out Soon Work relating to this issue has been completed. Generated Code Relates specifically to code contained in the generated project. WPF Relates to generated WPF projects
Projects
None yet
Milestone
3.9
Development

No branches or pull requests
4 participants
@mrlacey @punker76 @mvegaca @sibille