Skip to content
This repository has been archived by the owner on Jan 15, 2021. It is now read-only.

pxtroute: current 'export' button approach upsets popup blockers #496

Open
jaustin opened this issue Mar 24, 2017 · 0 comments
Open

pxtroute: current 'export' button approach upsets popup blockers #496

jaustin opened this issue Mar 24, 2017 · 0 comments
Assignees

Comments

@jaustin
Copy link

jaustin commented Mar 24, 2017

The current approach for the export button on the 'pxtroute' branch tries to pop up a window.

This appears to snag the popup blocker on Firefox and Chrome, and so means the first expereince the user has of a dialog that says "a window should have opened" but probably it hasn't.

I think this could easily be resolved like this:
Modify the dialogue to say something like
"Export will take your script and import it into the editor at Microsoft MakeCode. It will be automatically upgraded to be compatible. <something about data sharing and how MakeCode behaves"

Then have an 'Open' and 'Cancel' button exactly as they are today.
@pelikhan did you encounter the popup button?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@jaustin @pelikhan and others