Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important changes for 4.2 #960

Closed
orta opened this issue Dec 11, 2020 · 2 comments
Closed

Important changes for 4.2 #960

orta opened this issue Dec 11, 2020 · 2 comments

Comments

@orta
Copy link
Contributor

orta commented Dec 11, 2020

  const dateOptions = {
     weekday: "long",
     year: "numeric",
     month: "long",
     day: "numeric",
   };

   const date = new Date().toLocaleString("en-US", dateOptions);

would now need to be

   const date = new Date().toLocaleString("en-US", {
     weekday: "long",
     year: "numeric",
     month: "long",
     day: "numeric",
   });

Or to use as const

@HolgerJeromin
Copy link
Contributor

Can/should we update the typing of querySelector, querySelectorAll and closest, too?

Ref #885 (comment)

@orta
Copy link
Contributor Author

orta commented Dec 21, 2020

It was, I used this issue to keep track of breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants