Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes for 4.3 #991

Closed
orta opened this issue Mar 11, 2021 · 5 comments
Closed

Breaking changes for 4.3 #991

orta opened this issue Mar 11, 2021 · 5 comments

Comments

@orta
Copy link
Contributor

orta commented Mar 11, 2021

For 4.3, we used the Mozilla browser-compat-data to remove types and features which are not used in any browser.

We base the lib.dom.d.ts on the specifications from W3C and WHATWG. These specifications are like all projects, and have some cruft on them over time. Now, we check the data powering caniuse.com to see if there are any implementations of a specification before including the types from that spec in the lib.dom.d.ts.

This is automated and running across a lot of specifications, so there's a possibility it has some overreach and we're open to bringing some back if we missed a common case. Some of the types removed: Account (this is now free to use in your own apps 🎉), AssertionOptions, RTCStatsEventInit, MSGestureEvent, DeviceLightEvent, MSPointerEvent, ServiceWorkerMessageEvent and WebAuthentication.

@Stef-Gijsberts
Copy link

Stef-Gijsberts commented Jun 19, 2021

(I'm not sure where to mention this. If there is a better place, please let me
know.)

I suspect the automation overreached. I think it removed
RTCRtpEncodingParameters.maxFramerate, which is supported in Safari. I think
the reason it was removed is that at the time of checking, there was no known
"Supported" status for any browser on the caniuse page. But just now, the
status for Safari was set to "Supported".

It might be worth considering to adjust the automation, such that it does not
remove a feature if its status for a major browser is "Unknown".

@orta
Copy link
Contributor Author

orta commented Jun 20, 2021

If we were to re-add, it wouldn't pass our heuristics which is at least two popular browser support it: https://github.com/microsoft/TypeScript-DOM-lib-generator#what-are-the-typescript-teams-heuristics-for-prs-to-the-dom-apis

So I think this was still right

@nainkunal933
Copy link

I would like to re-raise @Stef-Gijsberts concern regarding RTCRtpEncodingParameters.maxFramerate being removed from 4.3. This is a breaking change for us as well. It seems like since this was last visited maxFramerate's support has increased.

@orta is it possible to re-add maxFramerate if it passes the heuristics now?

@x-epoch
Copy link

x-epoch commented Oct 13, 2022

I also would like to re-raise this issue since all browsers with latest version are support maxFramerate now, and it is real an import interface for webRTC video control.

@orta
Copy link
Contributor Author

orta commented Oct 13, 2022

If you followed the linked issue, you'd see that we're open to PRs for it, #1380 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants