Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new ClassName() rules #411

Closed
rokoroku opened this issue Feb 3, 2017 · 2 comments
Closed

Support new ClassName() rules #411

rokoroku opened this issue Feb 3, 2017 · 2 comments

Comments

@rokoroku
Copy link

rokoroku commented Feb 3, 2017

TS and JS Grammar Extension version: 0.0.18 / latest

With VSCode 1.9 update, merging tmTheme grammar token has been broken:
https://code.visualstudio.com/updates/v1_9#_theme-matching-rules-now-respect-textmate-semantics

2017-02-03 12 21 36

Prior 1.9, we can colorize new Date() as yellow (so as function color) by using new.expr.entity.name.type rule, but we cannot colorize it with this way anymore.

I want to use different syntax for entity.name.type and new.expr.entity.name

So I'd request a new grammar like new.expr.entity.name to colorize Date from above screenshot.

@sheetalkamat
Copy link
Member

The scope for Date in your sample is:
source.ts meta.var.expr.ts new.expr.ts entity.name.type.ts
Using microsoft/vscode#17933 you should be colorize these accordingly. It doesn't need change in the grammar.

@rokoroku
Copy link
Author

rokoroku commented Feb 4, 2017

Oh, we can capture multiple grammar by using whitespace between tokens, got it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants