Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor errors with JavaScript syntax highlighter #418

Closed
aeschli opened this issue Feb 16, 2017 · 2 comments
Closed

Minor errors with JavaScript syntax highlighter #418

aeschli opened this issue Feb 16, 2017 · 2 comments

Comments

@aeschli
Copy link

aeschli commented Feb 16, 2017

From @bcherny on February 16, 2017 4:48

  • VSCode Version: 1.9.1
  • OS Version: OSX 10.12.2 Sierra

Steps to Reproduce:

function merge(as, bs) {
  let res = []
  let ia = 0
  let ib = 0
  while (ia < as.length && ib < bs.length) { // coloring broken
    if (as[ia] < bs[ib]) {
      res.push(as[ia++]) // coloring broken
    } else {
      res.push(bs[ib++]) // coloring broken
    }
  }
  return res.concat(as.slice(ia)).concat(bs.slice(ib)) // coloring broken
}

function mergesort(array) {
  if (array.length < 2) {
    return array
  }
  const mid = Math.floor(array.length / 2)
  return merge(mergesort(array.slice(0, mid)), mergesort(array.slice(mid)))
}

Copied from original issue: microsoft/vscode#20692

@aeschli
Copy link
Author

aeschli commented Feb 16, 2017

From @kumarharsh on February 16, 2017 7:50

+1. This is weird, as is not even a keyword in JS as far as i know...

@Nimzozo
Copy link

Nimzozo commented Mar 29, 2017

When I declare a method next for my object, it is not correctly colored (it's blue, but should be yellow).

var obj = {};
obj.next = function () {};

I use VSCode 1.10.2 with Dark+ (default dark) theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants