Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export declare class properties missing proper scopes #642

Closed
mjbvz opened this issue Aug 2, 2018 · 2 comments
Closed

export declare class properties missing proper scopes #642

mjbvz opened this issue Aug 2, 2018 · 2 comments

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Aug 2, 2018

From microsoft/vscode#55575

TS and JS Grammar Extension version: 0.0.43 / latest
Code

export declare class TestClient {
    private readonly test1;
}

Gets highlighted as:

screen shot 2018-08-02 at 1 04 26 pm

Looks like the scopes of the tokens are all:

variable.other.readwrite.alias.ts
meta.block.ts
meta.export.ts
source.ts
@nickzelei
Copy link

@mjbvz This should only be happening due to #643. My example from microsoft/vscode#55575 was just using this snippet as an example that the optional property was breaking multiple things.

When I paste the snippet above into a clean .d.ts file I do not see the highlighting issue.

@mjbvz
Copy link
Contributor Author

mjbvz commented Aug 2, 2018

Looks like there was a regression since VS Code 1.25. This was tested using the latest version of the grammar on VS Code insiders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants